Add changing visibility timeout for each call #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eaypek-tfh
reviewed
Dec 2, 2024
consumer.go
Outdated
| @@ -56,6 +55,7 @@ loop: | |||
| MaxNumberOfMessages: c.cfg.BatchSize, | |||
| WaitTimeSeconds: int32(5), | |||
| MessageAttributeNames: []string{"TraceID", "SpanID"}, | |||
| VisibilityTimeout: c.cfg.VisibilityTimeout, | |||
There was a problem hiding this comment.
in the scenario of client skipping to pass VisibilityTimeout, I think it will default to 0. I'm not sure what's gonna happen in that case - maybe message will be put back to the sqs directly after received?
I think it would be good to have a default value for it or setting c.cfg.VisibilityTimeout here only when it's bigger than 0?
eaypek-tfh
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes