Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add consumer with idle trigger #239

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Conversation

danielle-tfh
Copy link
Contributor

Notes

  • add a consumer with idle trigger. This consumer is identical the other SQS consumer but with an added feature of triggering logic after a certain idle time has been reached.
    • the idle trigger is triggered if no new message has been received.
  • This is a feature needed for MPCv2 where it relies on consistent traffic to know when to process requests in batch. If there is a sudden decrease in traffic, some old requests which were waiting to be batched could not be triggered until a new requests arrives.
    Note: We can not add a timeout in MPCv2 since it would require that all nodes timeout at the same time or they could go out of sync
  • POC PR can be found here: https://github.com/worldcoin/signup-service/pull/828

@danielle-tfh danielle-tfh requested a review from a team as a code owner October 10, 2024 14:31
@danielle-tfh danielle-tfh merged commit 12ccb36 into main Oct 11, 2024
7 checks passed
@danielle-tfh danielle-tfh deleted the POP-1894/add-timout-trigger branch October 11, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants