Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error message width #234

Merged
merged 1 commit into from
Jan 24, 2024
Merged

fix: error message width #234

merged 1 commit into from
Jan 24, 2024

Conversation

0xPenryn
Copy link
Collaborator

uses a fixed px value for width of error message to prevent formatting errors when root font-size is changed

uses a fixed px value for width of error message to prevent formatting errors when root font-size is changed
@0xPenryn 0xPenryn requested review from andy-t-wang and pdtfh January 22, 2024 21:39
Copy link

vercel bot commented Jan 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
idkit-js-example ✅ Ready (Inspect) Visit Preview Jan 22, 2024 9:39pm

@andy-t-wang
Copy link
Contributor

Could you post a screenshot before you merge with different screen sizes. One small one regular one big.

@0xPenryn
Copy link
Collaborator Author

Before fix:
Screenshot 2024-01-24 at 9 43 43 AM

After fix:
Screenshot 2024-01-24 at 9 44 19 AM

Can confirm the fix applies across all screen sizes (including mobile).

@0xPenryn 0xPenryn merged commit 8cbb64f into main Jan 24, 2024
7 checks passed
@0xPenryn 0xPenryn deleted the fix-error-width branch January 24, 2024 17:47
This was referenced Jan 24, 2024
@github-actions github-actions bot mentioned this pull request Mar 30, 2024
@github-actions github-actions bot mentioned this pull request Jul 19, 2024
@github-actions github-actions bot mentioned this pull request Aug 9, 2024
@github-actions github-actions bot mentioned this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants