feat!: World ID Bridge #127
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -0,0 +1,22 @@ | |||
| export enum AppErrorCodes { | |||
There was a problem hiding this comment.
let's make sure these error codes are exported for easy use
idkit/pnpm-lock.yaml
Outdated
| @@ -1,4 +1,8 @@ | |||
| lockfileVersion: '6.0' | |||
| lockfileVersion: '6.1' | |||
There was a problem hiding this comment.
let's remove WalletConnect deps
idkit/src/lib/crypto.ts
Outdated
| const encoder = new TextEncoder() | ||
| const decoder = new TextDecoder() | ||
|
|
||
| export const generateKey = (): Promise<CryptoKeyPair> => { |
| ) | ||
| } | ||
|
|
||
| export const exportKey = async (key: CryptoKey): Promise<string> => { |
There was a problem hiding this comment.
nit: make it explicit this is used to export the private key?
idkit/src/lib/crypto.ts
Outdated
| export const exportKey = async (key: CryptoKey): Promise<string> => { | ||
| const jwk = await window.crypto.subtle.exportKey('jwk', key) | ||
|
|
||
| return Buffer.from(JSON.stringify(jwk)).toString('base64') |
There was a problem hiding this comment.
is this the simplest encoding?
| credential_types, | ||
| action_description, | ||
| action: encodeAction(action), | ||
| external_nullifier: generateExternalNullifier(app_id, action).digest, |
There was a problem hiding this comment.
@m1guelpf we need to pass the external_nullifier to the app for the advanced on-chain cases and cases where devs aren't using the Dev Portal to register their apps/actions. however, I'm not sure if for the advanced on-chain use cases, this is the best way to do it, will devs rely on creating a "custom action" for this case?
|
Superseded by #156 |
No description provided.