refactor: Use built-in Spanner client library functions for protobufs #1808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
6 tasks
Marco-Premier
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Reviewed 50 of 50 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)
SanjayVas
force-pushed
the
sanjayvas-spanner-cleanup
branch
2 times, most recently
from
63c31fb
to
877f392
Compare
SanjayVas
commented
Sep 17, 2024
There was a problem hiding this comment.
Reviewed 8 of 8 files at r2.
Reviewable status:
SanjayVas
force-pushed
the
sanjayvas-spanner-cleanup
branch
from
877f392
to
7de8391
Compare
SanjayVas
commented
Sep 17, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.