refactor: Drop JSON debugging columns from Kingdom Spanner DB #1800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
SanjayVas
force-pushed
the
sanjayvas-spanner-json
branch
from
2b4c997
to
126235a
Compare
stevenwarejones
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Reviewed 28 of 28 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)
SanjayVas
force-pushed
the
sanjayvas-spanner-json
branch
from
126235a
to
38d0460
Compare
SanjayVas
force-pushed
the
sanjayvas-spanner-proto
branch
2 times, most recently
from
b7c21e8
to
ef8ea74
Compare
SanjayVas
force-pushed
the
sanjayvas-spanner-json
branch
2 times, most recently
from
2e532ea
to
21d4610
Compare
SanjayVas
force-pushed
the
sanjayvas-spanner-proto
branch
2 times, most recently
from
25a347b
to
af2806d
Compare
SanjayVas
force-pushed
the
sanjayvas-spanner-json
branch
2 times, most recently
from
6f2c1fc
to
b554918
Compare
SanjayVas
force-pushed
the
sanjayvas-spanner-proto
branch
from
af2806d
to
abb90dd
Compare
SanjayVas
force-pushed
the
sanjayvas-spanner-json
branch
from
b554918
to
33faffc
Compare
SanjayVas
force-pushed
the
sanjayvas-spanner-proto
branch
from
abb90dd
to
bb21fc5
Compare
SanjayVas
force-pushed
the
sanjayvas-spanner-json
branch
from
33faffc
to
7873983
Compare
SanjayVas
force-pushed
the
sanjayvas-spanner-proto
branch
from
bb21fc5
to
5f2c5b0
Compare
SanjayVas
force-pushed
the
sanjayvas-spanner-json
branch
from
7873983
to
7f23564
Compare
SanjayVas
force-pushed
the
sanjayvas-spanner-proto
branch
2 times, most recently
from
736d69c
to
ebc7b80
Compare
SanjayVas
force-pushed
the
sanjayvas-spanner-json
branch
2 times, most recently
from
da40f3e
to
7d68a80
Compare
SanjayVas
force-pushed
the
sanjayvas-spanner-proto
branch
from
ebc7b80
to
7876bc3
Compare
SanjayVas
force-pushed
the
sanjayvas-spanner-json
branch
from
7d68a80
to
de27bef
Compare
SanjayVas
force-pushed
the
sanjayvas-spanner-json
branch
from
de27bef
to
18c95af
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are no longer needed now that Cloud Spanner has native protobuf support.