refactor: Extract Details message type definitions in Kingdom internal API #1798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
6 tasks
SanjayVas
force-pushed
the
sanjayvas-details-proto
branch
from
63eb923
to
ba65ce2
Compare
SanjayVas
force-pushed
the
sanjayvas-details-proto
branch
from
ba65ce2
to
bc3c89e
Compare
…l API The Details messages are persisted in the underlying Spanner database. Extracting them simplifies the migration to native protobuf types in Cloud Spanner. This change maintains binary compatibility for all existing serialized message types.
SanjayVas
force-pushed
the
sanjayvas-details-proto
branch
from
bc3c89e
to
00db865
Compare
stevenwarejones
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Reviewed 95 of 95 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)
roaminggypsy
pushed a commit
that referenced
this pull request
Sep 13, 2024
…l API (#1798) The Details messages are persisted in the underlying Spanner database. Extracting them simplifies the migration to native protobuf types in Cloud Spanner. This change maintains binary compatibility for all existing serialized message types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Details messages are persisted in the underlying Spanner database. Extracting them simplifies the migration to native protobuf types in Cloud Spanner.
This change maintains binary compatibility for all existing serialized message types.