fix: Revert to old behavior of ValueBinder.toProtoBytes #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
SanjayVas
force-pushed
the
sanjayvas-spanner-proto
branch
from
dc98180
to
329bfba
Compare
The key behavioral difference is in the underlying Spanner type. While the difference is not noticable in most cases as the serialization is the same, anything which inspects the Spanner types will notice.
SanjayVas
force-pushed
the
sanjayvas-spanner-proto
branch
from
329bfba
to
97b46bf
Compare
Marco-Premier
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The key behavioral difference is in the underlying Spanner type. While the serialization is the same, anything which inspects the Spanner type will behave differently.
This partially reverts #272.