Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Crate Sourcing to Flag When Run as Workflow #17

Closed
alexhambley opened this issue Jun 7, 2024 · 0 comments
Closed

Refactor Crate Sourcing to Flag When Run as Workflow #17

alexhambley opened this issue Jun 7, 2024 · 0 comments
Assignees

Comments

@alexhambley
Copy link
Collaborator

alexhambley commented Jun 7, 2024

Currently, WorkflowHub is hardcoded in as a constant. This should be a flag when run as a workflow.
e.g. source -wfh should run the sourcing on workflow hub production server. Something like source -wfh dev should run the sourcing on workflow hub development server.

Part of a wider refactoring to run this application as a workflow

@alexhambley alexhambley changed the title Refactor Crate Sourcing to Refactor Crate Sourcing to Flag When Run as Workflow Jun 7, 2024
alexhambley added a commit that referenced this issue Jul 9, 2024
Updated the dockerfile to use a two stage process. Snakemake image is used as the runtime environment.
Supports / Partially addresses #17
alexhambley added a commit that referenced this issue Jul 9, 2024
Updated snakemake workflow to work with Dockerfile. Also fixes module not found error by exposing pythonpath. Partially addresses #17
alexhambley added a commit that referenced this issue Jul 11, 2024
Partially addresses #28 and #17
User can now provide range (e.g. --workflow-ids 1-40) or omit this to download all workflows
alexhambley added a commit that referenced this issue Jul 12, 2024
- Added get_max_id_from_files method.
- If --workflow-ids argument is not provided, created_files.json should contain all workflows downloaded. get_max_id_from_files() finds the maximum ID in the sourced workflows.
- Part of wider effort to address #17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants