Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iran Cities for WooCommerce #138

Closed
zarei-dev opened this issue Aug 23, 2022 · 5 comments
Closed

Iran Cities for WooCommerce #138

zarei-dev opened this issue Aug 23, 2022 · 5 comments
Assignees

Comments

@zarei-dev
Copy link

What's the best way for doing that?

I think we have 2 ways:

  1. Register states and cities on plugin activation as Terms (Benefits: User can change/add/remove Cities)
  2. Add states and cities by loading IR-state_cities.php every time (Benefits: No touch DB)

In way 2, I prefer to use something like this:

	$cities['XX'] = array(
		'YYY' => array(
			'City ',
			'Another City'
		),
		'ZZZ' => array(
			'City 3',
			'City 4'
		)
	);

Implementation example

@zarei-dev
Copy link
Author

@man4toman

In the second method, the user can change cities with a filter.

@man4toman
Copy link
Member

Hi @zarei-dev

Based on our experience, it is better to load this list from the code, it can be safe from users edit.

And please feel free to choose the best way :)

Thanks

@Michaelgimii
Copy link

This would be a super cool feature. Will the list of Iranian cities be added to parsidate plugin?

@zarei-dev
Copy link
Author

@Michaelgimii
Yes. I'm working on it.

@hamidrezayazdani hamidrezayazdani self-assigned this Apr 17, 2023
hamidrezayazdani added a commit that referenced this issue Apr 20, 2023
#138

Solved: Wrong behavior in sale price dates | #142
@hamidrezayazdani
Copy link
Contributor

Added in #152

hamidrezayazdani added a commit that referenced this issue Apr 20, 2023
#138

Solved: Wrong behavior in sale price dates | #142
hamidrezayazdani added a commit that referenced this issue Apr 20, 2023
#138

Solved: Wrong behavior in sale price dates | #142
hamidrezayazdani added a commit that referenced this issue Apr 20, 2023
#138

Solved: Wrong behavior in sale price dates | #142
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants