-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update test cases #155
Conversation
Other Columns tests assert the expected mark up. I think it is safe to presume that if the mark up is correct, the front-end website will render correctly in the browser.
ad259d1
to
fc67438
Compare
This was automated in the following: WordPress/gutenberg#38571
This was automated in the following: WordPress/gutenberg#38571
This was automated in the following: wordpress-mobile/gutenberg-mobile#5826
33777fa
to
67e7668
Compare
Manually or automatically testing animations feels like a low return on effort required.
Manually or automatically testing animations feels like a low return on effort required.
@fluiddot removing the color settings animation test cases is aggressive. Feel free to push back if you disagree. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing animations — whether manually or automatically — seems like a low return of value for the effort required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I completely agree, I don't see them as a critical flow that needs to be tested.
|
||
##### TC010 | ||
|
||
### Columns percentage mechanism - custom percentage values are rendered correctly on frontend |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other automated Columns tests assert the expected mark up. I think it is safe to presume that if the mark up is correct, the front-end website will render correctly in the browser.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, as pointed out, we are already checking the HTML content related to the column's width (reference). So this test case is not really adding value to the test coverage 👍 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These test cases were automated in WordPress/gutenberg#38571.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
@@ -28,21 +28,6 @@ Use Simple WordPress.com site with a Premium plan. Free or Personal plans only a | |||
|
|||
<img src="../../test-cases/resources/../resources/videopress-upload-video-4.png" width="360"> | |||
|
|||
##### TC002 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test case was automated in wordpress-mobile/gutenberg-mobile#5826.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎊 ! Thanks @dcalhoun for cleaning up the test cases 🙇 !
I only added a comment regarding an image we could also remove as won't be referenced anymore. Apart from that, the PR is good to go 🎊 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I completely agree, I don't see them as a critical flow that needs to be tested.
|
||
##### TC010 | ||
|
||
### Columns percentage mechanism - custom percentage values are rendered correctly on frontend |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, as pointed out, we are already checking the HTML content related to the column's width (reference). So this test case is not really adding value to the test coverage 👍 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
* Tap the block settings icon ⚙️ :gear: | ||
* Tap `Link to` setting | ||
* For each of the settings | ||
* <img src="../../test-cases/resources/gallery-settings-link-to.png" width="360"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image is only referenced here so we can also remove it.
Update test cases to note known issues and remove automated or low-value test cases.