Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update test cases #155

Merged
merged 8 commits into from
Aug 29, 2023
Merged

docs: Update test cases #155

merged 8 commits into from
Aug 29, 2023

Conversation

dcalhoun
Copy link
Member

@dcalhoun dcalhoun commented Aug 25, 2023

Update test cases to note known issues and remove automated or low-value test cases.

  • docs: Capture Attachment Page known issue
  • docs: Remove TC010 Columns front-end presentation test
  • docs: Remove TC010 Gallery rearrange items test
  • docs: Remove TC012 Gallery Link to test
  • docs: Remove TC002 VideoPress caption test
  • docs: Remove TC001 Color settings segmented controls test
  • docs: Remove TC004 Color settings swatch press test

Other Columns tests assert the expected mark up. I think it is safe to
presume that if the mark up is correct, the front-end website will
render correctly in the browser.
@dcalhoun dcalhoun force-pushed the docs/update-test-cases branch from ad259d1 to fc67438 Compare August 25, 2023 18:14
@dcalhoun dcalhoun force-pushed the docs/update-test-cases branch from 33777fa to 67e7668 Compare August 25, 2023 20:12
Manually or automatically testing animations feels like a low return on
effort required.
Manually or automatically testing animations feels like a low return on
effort required.
@dcalhoun dcalhoun marked this pull request as ready for review August 25, 2023 20:20
@dcalhoun dcalhoun requested a review from fluiddot August 25, 2023 20:21
@dcalhoun
Copy link
Member Author

@fluiddot removing the color settings animation test cases is aggressive. Feel free to push back if you disagree.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing animations — whether manually or automatically — seems like a low return of value for the effort required.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I completely agree, I don't see them as a critical flow that needs to be tested.


##### TC010

### Columns percentage mechanism - custom percentage values are rendered correctly on frontend
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other automated Columns tests assert the expected mark up. I think it is safe to presume that if the mark up is correct, the front-end website will render correctly in the browser.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, as pointed out, we are already checking the HTML content related to the column's width (reference). So this test case is not really adding value to the test coverage 👍 .

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These test cases were automated in WordPress/gutenberg#38571.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@@ -28,21 +28,6 @@ Use Simple WordPress.com site with a Premium plan. Free or Personal plans only a

<img src="../../test-cases/resources/../resources/videopress-upload-video-4.png" width="360">

##### TC002
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test case was automated in wordpress-mobile/gutenberg-mobile#5826.

Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎊 ! Thanks @dcalhoun for cleaning up the test cases 🙇 !

I only added a comment regarding an image we could also remove as won't be referenced anymore. Apart from that, the PR is good to go 🎊 .

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I completely agree, I don't see them as a critical flow that needs to be tested.


##### TC010

### Columns percentage mechanism - custom percentage values are rendered correctly on frontend
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, as pointed out, we are already checking the HTML content related to the column's width (reference). So this test case is not really adding value to the test coverage 👍 .

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

* Tap the block settings icon ⚙️ :gear:
* Tap `Link to` setting
* For each of the settings
* <img src="../../test-cases/resources/gallery-settings-link-to.png" width="360">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is only referenced here so we can also remove it.

@dcalhoun dcalhoun merged commit 430bfdf into trunk Aug 29, 2023
@dcalhoun dcalhoun deleted the docs/update-test-cases branch August 29, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants