Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 12.3.4 into trunk #620

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Release 12.3.4 into trunk #620

merged 1 commit into from
Dec 2, 2024

Conversation

iangmaia
Copy link
Contributor

@iangmaia iangmaia commented Dec 2, 2024

Releasing new version 12.3.4.

What's Next

PR Author: Be sure to create and publish a GitHub Release pointing to trunk once this PR gets merged,
copy/pasting the following text as the GitHub Release's description:

### Bug Fixes

- `DateVersionCalculator`: move next year calculation decision to the clients [#619]

### Internal Changes

- Remove Danger check for milestones, as we don't really use GitHub milestones in this repo. [#617]

@iangmaia iangmaia added the Releases Release related stuff label Dec 2, 2024
@iangmaia iangmaia requested a review from a team December 2, 2024 11:57
@iangmaia iangmaia self-assigned this Dec 2, 2024
@iangmaia iangmaia merged commit 71095be into trunk Dec 2, 2024
6 of 7 checks passed
@iangmaia iangmaia deleted the release/12.3.4 branch December 2, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AliSoftware AliSoftware AliSoftware approved these changes

Assignees

@iangmaia iangmaia

Labels
Releases Release related stuff
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iangmaia @AliSoftware