Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid adding empty links to text #706

Merged
merged 4 commits into from
Mar 7, 2019
Merged

Avoid adding empty links to text #706

merged 4 commits into from
Mar 7, 2019

Conversation

etoledom
Copy link
Contributor

@etoledom etoledom commented Mar 6, 2019

This PR updates the gutenberg ref to test WordPress/gutenberg#14270

link

To test:

@etoledom etoledom added the [Type] Enhancement Improves a current area of the editor label Mar 6, 2019
@etoledom etoledom added this to the v1.1 milestone Mar 6, 2019
@etoledom etoledom self-assigned this Mar 6, 2019
@etoledom etoledom requested a review from mzorz March 6, 2019 12:51
@etoledom etoledom mentioned this pull request Mar 6, 2019
Merged
mzorz
mzorz approved these changes Mar 7, 2019
View reviewed changes
Copy link
Contributor

@mzorz mzorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works as advertised.
LGTM! :shipit:

@etoledom etoledom merged commit ed4823a into develop Mar 7, 2019
@etoledom
Copy link
Contributor Author

etoledom commented Mar 7, 2019

Thank you!

@etoledom etoledom deleted the issue/703-avoid-adding-empty-link branch March 7, 2019 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzorz mzorz mzorz approved these changes

Assignees

@etoledom etoledom

Labels
[Type] Enhancement Improves a current area of the editor
Projects
None yet
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@etoledom @mzorz