[RNMobile] Add url option to image block

[derekblank]

This is a PR for running CI checks on gutenberg#40334.

To test: N/A

PR submission checklist:

• I have considered adding unit tests where possible.
• I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

[peril-wordpress-mobile]

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

[derekblank]

@fluiddot I believe this is the correct way to keep the Gutenberg ref updated for gutenberg#40334. Let me know if I've missed something for the matching Gutenberg Mobile PR here. 🙇

[fluiddot]

@fluiddot I believe this is the correct way to keep the Gutenberg ref updated for WordPress/gutenberg#40334. Let me know if I've missed something for the matching Gutenberg Mobile PR here. 🙇

@derekblank Yeah, this is the correct way although I spotted a couple of issues that we'd need to check:

• We shouldn't modify the .gitmodules.
• The Gutenberg reference should point to the latest commit, now it's pointing to ee61ccb3b1eabce9dbc32fbd6c47cc64277002e7 but the last commit from the Gutenberg PR is a43fce12c6bd88c4b2307283186a1a54a3b2967b.

Additionally, it would be great to add an entry to the changelog files as outlined in the PR's submission checklist:

I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

On a different note, you can also generate this PR automatically by adding the Mobile app - Automation label to the Gutenberg PR (here you can check an example).

[fluiddot]

Approved via WordPress/gutenberg#40334 (review).

NOTE: Before merging the PR, the Gutenberg reference should point to the merge commit in trunk after merging the Gutenberg PR.

[derekblank]

@fluiddot Thanks for the tips! The automated PR would've been much easier. :) I think I had my wires crossed for a second, but I think I've sorted it out now after updating the changelog and the gutenberg refs. Since this PR is not automated and I cannot merge gutenberg#40334 myself, I think the next step for this PR is just to keep the submodule updated until the gutenberg PR can be merged?

[fluiddot]

I think I had my wires crossed for a second, but I think I've sorted it out now after updating the changelog and the gutenberg refs. Since this PR is not automated and I cannot merge WordPress/gutenberg#40334 myself, I think the next step for this PR is just to keep the submodule updated until the gutenberg PR can be merged?

@derekblank Yeah exactly, the next step for this PR before merging it is to update the Gutenberg reference once WordPress/gutenberg#40334 is merged.

Since you don't have permission to merge, I can take over that 👍. In relation to this, I'll restart the failing jobs in the Gutenberg PR (looks like they fail due to flakiness) and once everything is 🟢 I'll merge it. I'll let you know when it's merged so you can update the Gutenberg reference here.

[fluiddot]

@derekblank I've just merged the Gutenberg PR, here is the commit SHA: 20f6ca5806b753593496d2c7bf80f5bd643b34a1.

[fluiddot]

We usually add a reference to the Gutenberg Mobile PR along with the entry, e.g.:

[a11y] Improve text read by screen readers for BottomSheetSelectControl [https://github.com/wordpress-mobile/gutenberg-mobile/pull/4854]

Could you also add it for this change? Thanks 🙇 !

[derekblank]

@fluiddot Thanks for merging the Gutenberg PR. I've updated the release notes, and set the gutenberg reference to 20f6ca5806b753593496d2c7bf80f5bd643b34a1.

For non-automated gutenberg-mobile PRs (like this one), when the associated gutenberg PR has been merged, would the author (i.e., me) then merge the gutenberg-mobile PR? Or is there another approval step needed? I see all of the checks have passed but I just want to confirm that it is ok to merge 🙇 .

[fluiddot]

@fluiddot Thanks for merging the Gutenberg PR. I've updated the release notes, and set the gutenberg reference to 20f6ca5806b753593496d2c7bf80f5bd643b34a1.

🎊

For non-automated gutenberg-mobile PRs (like this one), when the associated gutenberg PR has been merged, would the author (i.e., me) then merge the gutenberg-mobile PR? Or is there another approval step needed? I see all of the checks have passed but I just want to confirm that it is ok to merge 🙇 .

Yeah, once both Gutenberg and Gutenberg-Mobile PRs are approved and ready to merge, usually the author is in charge of updating the references and merging the PRs. In this case, since everything is ready, including the PR checks, you can go ahead and merge the PR .

This also applies to the automated Gutenberg-Mobile PRs, as only updating the Gutenberg reference is the part automated. Update the reference to point to the merge commit and PR merging is still manual.