Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.71.0 #4543

Merged
merged 81 commits into from
Feb 3, 2022
Merged

Release 1.71.0 #4543

merged 81 commits into from
Feb 3, 2022

Conversation

SiobhyB
Copy link
Contributor

@SiobhyB SiobhyB commented Feb 3, 2022 •
edited
Loading

Release for Gutenberg Mobile 1.71.0

Related PRs

Extra PRs that Landed After the Release Was Cut

Change 1

Note, this change also set to be included in a beta release (1.70.2) which is why it isn't included in this release's notes. It addresses a crash on production that affected some users using block-based themes and custom link colors.

Change 2

Non-user facing change that was necessary to cherry-pick in order to fix a failing test on Gutenberg's trunk.

Changes

Change 1

If an Image block is set as the post's Featured Image, replacing the Image block's media will now prompt the user as to whether they want to replace the Featured Image as well.

Change 2

Font size and line-height support have been introduced for text-based blocks used in block-based themes. These will be available in the block's settings and visible via the in-editor preview as the user changes settings.

Test plan

Once the installable builds of the main apps are ready, perform a quick smoke test of the editor on both iOS and Android to verify it launches without crashing. We will perform additional testing after the main apps cut their releases.

Release Submission Checklist

  • Verify Items from test plan have been completed
  • Check if RELEASE-NOTES.txt is updated with all the changes that made it to the release. Replace Unreleased section with the release version and create a new Unreleased section.
  • Check if gutenberg/packages/react-native-editor/CHANGELOG.md is updated with all the changes that made it to the release. Replace ## Unreleased with the release version and create a new ## Unreleased.
  • Bundle package of the release is updated.

dcalhoun and others added 30 commits September 9, 2021 09:11
@dcalhoun
Update gutenberg ref
4196e68
@dcalhoun
Update gutenberg ref
989ad07
@dcalhoun
Generate bundle
40ed443
@dcalhoun
Update gutenberg ref
983f4c3
@dcalhoun
Generate bundle
8fc364d
@dcalhoun
Update gutenberg ref
0793f3d
@dcalhoun
Generate bundle
7f7b8ae
@dcalhoun
Update gutenberg ref
580b6f5
@dcalhoun
Generate bundle
7486dbb
@dcalhoun
Update release notes
4ea5d3d
@dcalhoun
Update gutenberg ref
31ab226
@dcalhoun
Generate bundle
cdd60f3
@fluiddot
Fix headings of i18n section in README
7a758dc
@fluiddot
Improve string replacements for android lint rules
660d8f7
@fluiddot
Update Android localization strings file
c1807c0
@fluiddot
Update Gutenberg ref
49c8cba
@fluiddot
Bump Jest version to v27
a39b60c
@fluiddot
Revert wrong prettier package in package-lock.json
d000016
@fluiddot
Use default jest environment
3991c82
@fluiddot
Remove unused jest config property
be8113d
@fluiddot
Update jetpack editor setup tests
6ea14fb 
It's not longer required to isolate modules for registering jetpack blocks.
@fluiddot
Update Gutenberg ref
e0daf25
@fluiddot
Refactor gb-mobile tests
d53be70
@fluiddot
Rename jest-junit output env variable
3e27bcb
@fluiddot
Rename ellipsis pattern in strings2android
6c14c28
@fluiddot
Update Gutenberg ref
8b3d612
@fluiddot
Update editor rendering test case
3d93d49
@fluiddot
Update Gutenberg ref with merge commit
7273f34
@fluiddot
Merge pull request #4499 from wordpress-mobile/update/bump-jest-versi…
6169e94 
…on-v27

Bump Jest version to v27
@fluiddot
Merge branch 'develop' into merge_release_1.70.0_to_develop
2c582b0
This was referenced Feb 3, 2022
Merged
Merged
Merged
@SiobhyB SiobhyB marked this pull request as ready for review February 3, 2022 10:46
mchowning
mchowning approved these changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look right. Tested both WPAndroid and WPiOS, confirmed the editor loads and smoke tested a bit of the editor functionality. Everything appears to be working as expected.

@mchowning mchowning merged commit 39f25b8 into trunk Feb 3, 2022
@mchowning mchowning deleted the release/1.71.0 branch February 3, 2022 19:41
@SiobhyB
Copy link
Contributor Author

SiobhyB commented Feb 8, 2022 •
edited
Loading

🟡 Writing Flow Test Cases (Android)

Tested with build 19.2-rc-1 on a Pixel 5 (Android 12).

General

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC001 - Highlight selected text
  • TC001 - Highlight text without selection
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
Splitting and merging
  • TC001 - Merge after writing
    • Paragraph
    • Heading
  • TC002 - Merge after selection
    • Paragraph
    • Heading
  • TC003 - Merge after deleting text
    • Paragraph
    • Heading
  • TC004 - Merge after deleting all
    • Paragraph
    • Heading
  • TC005 - Merge multiple blocks
    • Paragraph
    • Heading
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@SiobhyB
Copy link
Contributor Author

SiobhyB commented Feb 8, 2022 •
edited
Loading

🟡 Test Suite 4 (Android)

Tested with build 19.2-rc-1 on a Pixel 5 (Android 12).

DarkMode - 2

  • Spacer block - Dark mode - TC004
  • Buttons block - Dark mode - TC005
  • Group - Dark mode - TC006
  • Columns - Dark mode - TC007

Group - 2

  • Group - Navigation up button works as expected - TC009
  • Group - Navigation down works according to parent-first approach - TC010
  • Group - Cross navigation between blocks works as expected - TC011
  • Group - Ungroup button works as expected - TC012
  • Group - Check if in DarkMode all components gets proper colors - TC013
  • Group - Check if nested Placeholder block can be replaced - TC014

Spacer - 2

Buttons - 4

  • Buttons block - Render custom text color - TC017
  • Buttons block - Render custom background color - TC016
  • Buttons block - Render gradient background color - TC018
  • Buttons block - Check if selection / caret color matches font color - TC020
  • Buttons block - The newly created Buttons has set background color to the theme-default color in preview - TC021

Buttons - 5

  • Buttons block - Edit text styles - TC009
  • Buttons block - Render theme colors - TC019
  • Buttons block - Settings: Change Button border radius - TC015

Buttons - 7

  • Buttons block - Link from the clipboard is presented as an option in the link picker - TC008
  • Buttons block - Toolbar link button is active when Button has link - TC022

Editor Theme - 2

  • Custom Gradients - Check that custom gradients load in the editor - TC004
  • Offline Support - TC005

Color Settings - 2

  • Pressing color swatch - TC004
  • Customize gradient color - TC005
  • Custom color picker - TC006

@SiobhyB
Copy link
Contributor Author

SiobhyB commented Feb 8, 2022 •
edited
Loading

🟢 Test Suite 5 (Android)

Tested with build 19.2-rc-1 on a Pixel 5 (Android 12).

Video block - 1

  • Video block - Insert video from device (failing) - steps
  • Video block - Close/Re-open post with an ongoing video upload - steps

Video block - 2

  • Video block - Insert video from device (cancel) - steps
  • Video block - Close post with an ongoing video upload - steps
  • Video block - Add Caption - steps

File block - 1

  • File block - Upload completes successfully from the device library - steps
  • File block - Insert completes successfully from the WordPress Media library - steps
  • File block - Upload fails from the device library - steps
  • File block - Stop the file upload before it completes - steps

File block - 2

  • File block - Close the post with an ongoing file upload - steps
  • File block - Replace the selected files - steps
  • File block - Change the alignment in the File Block - steps
  • File block - The Link To Block Setting should open - steps

File block - 3

  • File block - Open link in new tab - steps
  • File block - Show/hide download button (Block Settings only) - steps
  • File block - Copy file URL - steps
  • File block - Close/Re-open post with an ongoing file upload - steps

Audio block - 1

  • Audio block - Upload completes successfully from the device library - steps
  • Audio block - Insert completes successfully from the WordPress Media library - steps

Audio block - 2

  • Audio block - Upload fails from the device library - steps
  • Audio block - Stop the audio file upload before it completes - steps

Audio block - 3

  • Audio block - Close the post with an ongoing audio file upload - steps
  • Audio block - Replace the selected files - steps
  • Audio block - Change the alignment in the Audio Block - steps

Audio block - 4

  • Audio block - Autoplay setting - steps
  • Audio block - Loop setting - steps
  • Audio block - Close/Re-open post with an ongoing audio file upload - steps

Reusable block - 1

  • Reusable block - Add block - steps
  • Reusable block - Convert to regular blocks - steps

Reusable block - 2

  • Reusable block - Deleted reusable block - steps
  • Reusable block - Recursive block rendering - steps

Embed block - 1

  • Embed block - Inline previews are rendered correctly for the top 5 most-used providers - steps

Embed block - 2

  • Embed block - Inline previews are rendered accordingly for each alignment option - steps

@SiobhyB
Copy link
Contributor Author

SiobhyB commented Feb 8, 2022 •
edited
Loading

🟢 New Changes (Android)

Tested with build 19.2-rc-1 on a Pixel 5 (Android 12).

@SiobhyB
Copy link
Contributor Author

SiobhyB commented Feb 8, 2022 •
edited
Loading

🟢 Unsupported Block Tests (Android)

Tested with build 19.2-rc-1 on a Pixel 5 (Android 12).

  • TC001 User can edit unsupported blocks on Simple WP.com sites
  • TC002 User can discard edits to an unsupported block on Simple WP.com sites
  • TC003 Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
  • TC004 Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
  • TC005 Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
  • TC006 Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password

@mchowning
Copy link
Contributor

mchowning commented Feb 8, 2022 •
edited
Loading

🟢 New Changes (iOS)

Tested with internal build 19.2.0.20220207 on an iPhone XR (14.7.1).

@mchowning
Copy link
Contributor

mchowning commented Feb 8, 2022 •
edited
Loading

🟡 Writing Flow Test Cases (iOS)

Tested with internal build 19.2.0.20220207 on an iPhone XR (14.7.1).

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
    • Quote block
    • Verse block
    • Preformatted block
    • Code block (DEV only)
    • Pullquote block

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC001 - Highlight selected text
  • TC001 - Highlight text without selection
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
Splitting and merging
  • TC001 - Merge after writing
    • Paragraph
    • Heading
  • TC002 - Merge after selection
    • Paragraph
    • Heading
  • TC003 - Merge after deleting text
    • Paragraph
    • Heading
  • TC004 - Merge after deleting all
    • Paragraph
    • Heading
  • TC005 - Merge multiple blocks
    • Paragraph
    • Heading
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@mchowning
Copy link
Contributor

mchowning commented Feb 8, 2022 •
edited
Loading

🟢 Unsupported Block Tests (iOS)

Tested with internal build 19.2.0.20220207 on an iPhone XR (14.7.1).

  • TC001 User can edit unsupported blocks on Simple WP.com sites
  • TC002 User can discard edits to an unsupported block on Simple WP.com sites
  • TC003 Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
  • TC004 Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
  • TC005 Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
  • TC006 Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password

@mchowning
Copy link
Contributor

mchowning commented Feb 8, 2022 •
edited
Loading

🟢 Test Suite 3 (iOS)

Tested with internal build 19.2.0.20220207 on an iPhone XR (14.7.1).

Gallery - 2

  • Gallery block - Insert image from device (failing) - TC006
  • Gallery block - Insert image from device (cancel) - TC009

Gallery - 3

  • Gallery block - Add Gallery Caption - TC003
  • Gallery block - Add Gallery Image Caption - TC004
  • Gallery block - Try adding same images from WP Media library and moving the images around - TC010

Gallery - 4

  • Gallery block - Settings: Link to - TC012
  • Gallery block - Settings: Column number - TC013
  • Gallery block - Settings: Crop images - TC014

Columns - 2

  • Columns - Max limit of Column number - steps
  • Columns - Min limit of Column number - steps
  • Columns - Removing Column with remove button - steps
  • Columns - Removing the only one left Column with remove button - steps
  • Columns - Changing alignment on Columns - steps
  • Columns - Changing alignment on individual Columnn - steps
  • Columns - Alignment attribute is properly passed when adding Column - steps
  • Columns - Deep nesting is possible (iOS only)- steps

Columns - 3

  • Columns - Check if Column placeholders is visible for the unselected state - steps
  • Columns - Appearance in vertical device position (vertical layout) - steps
  • Columns - Appearance in horizontal device position (horizontal layout) - steps
  • Columns - Mover direction - steps
  • Columns - Check if Column placeholder is render in nested structure - steps
  • Columns - Unselected Column placeholder is streched to content in nested structure- steps

Columns - 4

  • Columns - Check if in DarkMode all components gets proper colors - steps

MediaText - 3

  • Media Text block - Insert video from device (failing) - TC001-v
  • Media Text block - Close/Re-open post with an ongoing video upload - TC003-v

MediaText - 4

  • Media Text block - Media & Text alignment - TC006
  • Media Text block - Vertical alignment - TC007

Shortcode-1

  • Shortcode block - Add a youtube link - steps

Cover - 2

Identified a couple of small issues with the cover block, but they are relatively minor issues and not regressions, nothing we need to address immediately: Cover block is empty after media is cleared and Inconsistency when replacing media on cover block.

  • Cover - Add Video Background from WordPress Media library - TC005
  • Cover - Replace media - TC006
  • Cover - Gradient background is rendered properly - TC007
  • Cover - Gradient overlay is rendered properly - TC008

Social Icons - 2

  • The link sheet is opened automatically when adding new icon - TC004
  • Ghost placeholder is visible when no icon is active - TC005
  • Social icon forwarding to the link - TC006

Image - 2

  • Image block - Border style setting - TC006
  • Image block - Image size setting - TC007
  • Image block - Link to setting - TC008

Story block - 1

  • Story block - Verify is available in Block Picker - TC001
  • Story block - Verify is not available in Block Picker- TC002
  • Story block - Add media to empty Story block - TC003
  • Story block - Add media to non-empty Story block - TC004
  • Story block - Close/Re-open post with an ongoing Story upload - TC005

@SiobhyB SiobhyB mentioned this pull request Feb 8, 2022
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchowning mchowning mchowning approved these changes

Assignees
No one assigned
Labels
release-process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@SiobhyB @mchowning @dcalhoun @fluiddot @wpmobilebot @geriux @hypest