Closing the block inserter decrements block type impressions #3802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
mchowning
approved these changes
Aug 5, 2021
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
…e into update/closing-inserter-decrements-block-type-impressions
dcalhoun
deleted the
update/closing-inserter-decrements-block-type-impressions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to WordPress/gutenberg#33907. Closing the block inserter will decrement the block type impression counts. This results in blocks that are marked as "new" to slowly lose the designation as a user utilizes the block inserter over time.
To test: See WordPress/gutenberg#33906.
PR submission checklist: