-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style using CSS Modules #36
Merged
Merged
Changes from 6 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
01d7317
Initial support for loading .scss style files
hypest f359c38
Load styles from the CSS module for block-manager
hypest fcffc1d
Load native CSS module in plain-text
hypest 4c51133
Use a CSS module for block-holder styling
hypest 712860c
Set the core/code styling
hypest 9d86bf5
Mock the CSS modules in Jest test for now
hypest 05b1dd8
Set Code block font to Courier
hypest 8d0821b
Scss file for the toolbar as well
hypest 74c88a6
No need for explicit mobile native extension
hypest 583335d
Platform specific font family for the code block
hypest dd23ef4
Mock scss loading for Flow
hypest 686c0a3
Enable Prettier for the scss files
hypest 590fea5
Explicitly set flexBasis to auto
hypest 89d7911
Only list scss files in "scssfiles"
hypest File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
/** @format */ | ||
|
||
module.exports = {}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
.block_code { | ||
font-family: monospace; | ||
} | ||
|
||
.blockHolder { | ||
flex: 1; | ||
} | ||
|
||
.blockContainer { | ||
background-color: white; | ||
} | ||
|
||
.blockContent { | ||
padding-left: 10; | ||
padding-right: 10; | ||
padding-top: 10; | ||
padding-bottom: 10; | ||
} | ||
|
||
.blockTitle { | ||
background-color: grey; | ||
padding-left: 10; | ||
padding-top: 4; | ||
padding-bottom: 4; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
.container { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should maybe start adding There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good idea! Done with 686c0a3. |
||
flex: 1; | ||
justify-content: flex-start; | ||
background-color: #caa; | ||
} | ||
|
||
.list { | ||
flex: 1; | ||
background-color: #ccc; | ||
} | ||
|
||
.htmlView { | ||
flex: 1; | ||
background-color: #fff; | ||
} | ||
|
||
.switch { | ||
flex-direction: row; | ||
justify-content: flex-start; | ||
} |
Submodule gutenberg
updated
3 files
+3 −2 | blocks/library/code/edit.native.js | |
+2 −2 | blocks/plain-text/index.native.js | |
+16 −0 | blocks/plain-text/style.native.scss |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
/** @format */ | ||
|
||
module.exports = { | ||
getTransformModulePath() { | ||
return require.resolve( 'react-native-sass-transformer' ); | ||
}, | ||
getSourceExts() { | ||
return [ 'scss', 'sass' ]; | ||
}, | ||
}; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are
ios.scss
andandroid.scss
missing from this list?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, there is no need for the
native.scss
anyway so, removed with 74c88a6.