[Android] Fix Gboard enter detection in EnterPressedWatcher #3590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
dcalhoun
previously requested changes
Jun 16, 2021
mkevins
approved these changes
Jun 16, 2021
AmandaRiu
dismissed
dcalhoun’s stale review
Another review not needed as approved by Matthew Kevins and these are small changes.
mokagio
added a commit
to wordpress-mobile/WordPress-iOS
that referenced
this pull request
Jun 29, 2021
See title in the PR that was linked to it (wordpress-mobile/gutenberg-mobile#3590): > [Android] Fix Gboard enter detection in EnterPressedWatcher If you then follow up on the Gutenberg PR (WordPress/gutenberg#32471) that actually made the change, you'll see confirmation it's Android only: > [RNMobile] Android Only - Fix Gboard enter detection in > EnterPressedWatcher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3316
Gutenberg PR: WordPress/gutenberg#32471
To test:
See testing instructions in the gutenberg PR.
PR submission checklist: