Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SVG styling #322

Merged
merged 1 commit into from
Dec 6, 2018
Merged

Fix SVG styling #322

merged 1 commit into from
Dec 6, 2018

Conversation

Tug
Copy link
Contributor

@Tug Tug commented Dec 5, 2018

Fixes #320
Requires WordPress/gutenberg#12608

This PR fixes a regression on SVG styling I introduced in #310.

Testing Instructions

  • Boot the app on ios and android
  • Check that the buttons are not black but light gray

@Tug Tug self-assigned this Dec 5, 2018
@Tug Tug requested a review from marecar3 December 5, 2018 08:57
@@ -901,25 +901,31 @@
resolved "https://registry.yarnpkg.com/@types/semver/-/semver-5.5.0.tgz#146c2a29ee7d3bae4bf2fcb274636e264c813c45"
integrity sha512-41qEJgBH/TWgo5NFSvBCJ1qkoi3Q6ONSF2avrHq1LVEZfYpdHmj0y9SuTK+u9ZhG1sYQKBL1AWXKyLWP4RaUoQ==

"@wordpress/babel-plugin-import-jsx-pragma@file:gutenberg/packages/babel-plugin-import-jsx-pragma":
"@wordpress/babel-plugin-import-jsx-pragma@^1.1.2":
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like yarn.lock is not up to date in master, let's update it!

@marecar3
Copy link
Contributor

marecar3 commented Dec 6, 2018

Hey @Tug , there are some conflicts on this branch.

@Tug
Copy link
Contributor Author

Tug commented Dec 6, 2018

Yeah I'll just update gutenberg to the last mobile branch commit once it's merged 👍

Copy link
Contributor

@marecar3 marecar3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on both iOS and Android and it's working :)
Approeved!

@Tug Tug merged commit c8b4bce into master Dec 6, 2018
@Tug Tug deleted the fix/svg-styles branch December 6, 2018 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants