Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sizeSlug does not update in Gallery block #2897

Merged
merged 6 commits into from
Dec 17, 2020

Conversation

mkevins
Copy link
Contributor

@mkevins mkevins commented Dec 14, 2020

Related PR:

gutenberg: WordPress/gutenberg#27691

To test (test on web and mobile):

  • Create a new post
  • Add a gallery block
  • Add a few images
  • Tap block settings
  • Change image size setting (try "Medium")

Expect the size setting to be reflected after selecting the option.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Dec 15, 2020

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

This reverts commit 52621b4.
Copy link

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change in the linked Gutenberg PR LGTM and behaves as expected 👍

ps. I've run npm install and pushed an update in the package-lock.json hopping to fix the failed Check Correctness. This didn't work 🤷 (reverted)
I then noticed that this fails in most open PRs at this point and should be a CI issue.

@enejb
Copy link
Contributor

enejb commented Dec 15, 2020

Thanks for working on this. I found this issue (#2880) when I was doing the santy testing. It seems to be the same issue.

@mkevins mkevins linked an issue Dec 16, 2020 that may be closed by this pull request
@mkevins mkevins merged commit 1f68289 into develop Dec 17, 2020
@mkevins mkevins deleted the fix/sizeSlug-not-updated branch December 17, 2020 07:52
@mkevins
Copy link
Contributor Author

mkevins commented Dec 17, 2020

Thanks for taking the time to review Antonis, and Enej for linking to the related issue. And thanks @Lovor01 for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gallery: Can't change the gallery image size.
3 participants