-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sizeSlug does not update in Gallery block #2897
Conversation
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
This reverts commit 52621b4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code change in the linked Gutenberg PR LGTM and behaves as expected 👍
ps. I've run npm install
and pushed an update in the package-lock.json
hopping to fix the failed Check Correctness. This didn't work 🤷 (reverted)
I then noticed that this fails in most open PRs at this point and should be a CI issue.
Thanks for working on this. I found this issue (#2880) when I was doing the santy testing. It seems to be the same issue. |
Thanks for taking the time to review Antonis, and Enej for linking to the related issue. And thanks @Lovor01 for the fix! |
Related PR:
gutenberg
: WordPress/gutenberg#27691To test (test on web and mobile):
Expect the size setting to be reflected after selecting the option.
PR submission checklist: