Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Image block - upload multiple #2530

Merged
merged 10 commits into from
Nov 9, 2020

Conversation

mkevins
Copy link
Contributor

@mkevins mkevins commented Aug 4, 2020

Related PRs

gutenberg: WordPress/gutenberg#24346
WordPress-Android: wordpress-mobile/WordPress-Android#12591

Description

This PR is a first step towards resolving the Android part of this issue: #2255

To test:

Test uploading multiple images from the image block:

  1. Add an image block to a new post
  2. Tap "ADD IMAGE"
  3. Tap "Choose from device" (observe that multiple images can be selected)
  4. Select a few images and tap "Insert"

Expected:

  • All images should be inserted as separate image blocks
  • Each image should show progress as it uploads
  • After upload completes, HTML mode should show a remote URL for the image (i.e. not "file://...")

Test the media upload flows for the following blocks to ensure there are no regressions:

Image block
  • Image block - Insert image from device (failing) - steps
  • Image block - Insert image from device (cancel) - steps
  • Image block - Close/Re-open post with an ongoing image upload - steps
Video block
  • Video block - Insert video from device (failing) - steps
  • Video block - Insert video from device (cancel) - steps
  • Video block - Close/Re-open post with an ongoing video upload - steps
Media & Text block
  • Media Text block - Insert image from device (failing) - steps
  • Media Text block - Insert video from device (failing) - steps
  • Media Text block - Insert image from device (cancel) - steps
  • Media Text block - Insert video from device (cancel) - steps
  • Media Text block - Close/Re-open post with an ongoing image upload - steps
  • Media Text block - Close/Re-open post with an ongoing video upload - steps
Gallery block
  • Gallery block - Choose from device (stay in editor) - Successful upload - steps
  • Gallery block - Choose from device (stay in editor) - Failed upload - steps
  • Gallery block - Close post with an ongoing image upload - steps
  • Gallery block - Close/Re-open post with an ongoing image upload - steps
  • Gallery block - Take a photo - steps
  • Gallery block - Choose from the free photo library - steps

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested all cases plus the new functionality. Nice work @mkevins!

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Nov 5, 2020

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@mkevins mkevins merged commit 1dd9305 into develop Nov 9, 2020
@mkevins mkevins deleted the try/image-block-upload-multiple branch November 9, 2020 01:12
@mkevins
Copy link
Contributor Author

mkevins commented Nov 9, 2020

Thanks for reviewing and testing Gerardo!

@ceyhun ceyhun mentioned this pull request Nov 9, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants