Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Social links/icons #2361

Closed
wants to merge 10 commits into from
Closed

Add Social links/icons #2361

wants to merge 10 commits into from

Conversation

lukewalczak
Copy link
Contributor

@lukewalczak lukewalczak commented Jun 9, 2020 •
edited
Loading

Fixes #2191

Ref to gutenberg: WordPress/gutenberg#23017

Testing:

To test:

  1. Open mobile app
  2. Add Social Icons

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 9, 2020 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@lukewalczak lukewalczak mentioned this pull request Jun 9, 2020
Merged
6 tasks
@lukewalczak lukewalczak force-pushed the social_links branch 2 times, most recently from 038db38 to 828a1c3 Compare June 19, 2020 10:15
@lukewalczak lukewalczak marked this pull request as ready for review June 25, 2020 15:46
@lukewalczak lukewalczak self-assigned this Jun 25, 2020
@lukewalczak lukewalczak added [Type] Enhancement Improves a current area of the editor Blocks labels Jun 25, 2020
@lukewalczak lukewalczak added this to the 1.33 milestone Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lukewalczak lukewalczak

Labels
Blocks [Type] Enhancement Improves a current area of the editor
Projects
None yet
Milestone
1.33
Development

Successfully merging this pull request may close these issues.

Add: Social icons block
1 participant
@lukewalczak