Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Insertion point marker shown without the Inserter open #1894

Merged
merged 1 commit into from
Feb 18, 2020

Conversation

dratwas
Copy link
Contributor

@dratwas dratwas commented Feb 12, 2020

This PR fixes an inserter point since it is rendered even if shouldn't

Gutenberg PR - WordPress/gutenberg#20195

To test:

  • Remove all from initial html
  • Click Add Block button
  • The inserter should be shown instead of paragraph placeholder - below the title
  • Add group block
  • Add a block in that group
  • The inserter shouldn't be visible after that action and should be in the right place when the bottom sheet is open (please swipe bottom sheet a bit to see if inserter is in the right place)
  • Click and hold on the Add Button (long press) and chose add before or add after and check if inserter is in the right place

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Copy link
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dratwas dratwas changed the base branch from develop to release/1.23.0 February 18, 2020 16:37
@mchowning mchowning merged commit ec68bab into release/1.23.0 Feb 18, 2020
@mchowning mchowning deleted the fix/inserter branch February 18, 2020 17:34
@hypest hypest changed the title [FIX] inserter Fix Insertion point marker shown without the Inserter open Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants