Remove react-native-aztec-old-submodule

[ceyhun]

react-native-aztec was moved into this repo a while ago and it's submodule was removed: #465
But this submodule was re-introduced again because of JitPack problems: #486
Seems like JitPack is not an issue anymore as the CI is green in this PR so we can remove this submodule now.

[Tug]

Changes looks good to me. Could you maybe open a PR on WPAndroid that targets this branch to make sure ewverything is ok now?

[ceyhun]

Android PR builds failed with a JitPack error:

https://jitpack.io/com/github/wordpress-mobile/gutenberg-mobile/fc7493eb81/build.log

Tried rebasing but got the same error:
https://jitpack.io/com/github/wordpress-mobile/gutenberg-mobile/c972d0d89a/build.log

@hypest maybe you have an idea?

[hypest]

Looking at the JitPack log:

jest-haste-map: Haste module naming collision: react-native-aztec
The following files share their name; please adjust your hasteImpl:

• /react-native-aztec-old-submodule/package.json
• /react-native-aztec/package.json

Looks like the "old-submodule" is still there. Not fully sure yet if this is essentially the same error that we got back in the day and that's why we decided to keep the old-submodule around 🤔 .

[hypest]

Or, perhaps we have to add a step in JitPack's config to rm -Rf the submodule folder which is probably checked out from the initial clone (before JitPack then switches the to branch under test). Does that make sense?

[ceyhun]

Not fully sure yet if this is essentially the same error that we got back in the day and that's why we decided to keep the old-submodule around 🤔 .

I think it was a different error before jitpack/jitpack.io#3707 mentioned here #486.

Or, perhaps we have to add a step in JitPack's config to rm -Rf the submodule folder which is probably checked out from the initial clone (before JitPack then switches the to branch under test). Does that make sense?

Let me try that 👍

[ceyhun]

It worked perfectly 🎉 Android build is now green as well: wordpress-mobile/WordPress-Android#11289

[SergioEstevao]