Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to gutenberg master #1799

Merged
merged 5 commits into from
Jan 22, 2020
Merged

Update to gutenberg master #1799

merged 5 commits into from
Jan 22, 2020

Conversation

koke
Copy link
Member

@koke koke commented Jan 22, 2020

Recent changes introduced the icons and primitives package and a new dependency for data.

To test:

  • Test should pass

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@koke koke added the Web breakage Caused by incompatible changes on Gutenberg web label Jan 22, 2020
@koke koke added this to the 1.22 milestone Jan 22, 2020
@koke
Copy link
Member Author

koke commented Jan 22, 2020

Icons package needs some changes, so I pushed WordPress/gutenberg#19810

@koke koke requested a review from geriux January 22, 2020 10:17
etoledom
etoledom approved these changes Jan 22, 2020
View reviewed changes
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it builds and run flawlessly 🎉
Thank you!

@koke koke merged commit e33cd1f into develop Jan 22, 2020
@koke koke deleted the update-master-20200122 branch January 22, 2020 11:15
@lukewalczak lukewalczak mentioned this pull request Jan 23, 2020
Closed
2 tasks
This was referenced Feb 3, 2020
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etoledom etoledom etoledom approved these changes

@geriux geriux Awaiting requested review from geriux

Assignees
No one assigned
Labels
Web breakage Caused by incompatible changes on Gutenberg web
Projects
None yet
Milestone
1.22
Development

Successfully merging this pull request may close these issues.
2 participants
@koke @etoledom