Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to RN 0.61, Hermes #1704

Merged
merged 42 commits into from
Jan 10, 2020
Merged

Update to RN 0.61, Hermes #1704

merged 42 commits into from
Jan 10, 2020

Conversation

hypest
Copy link
Contributor

@hypest hypest commented Dec 20, 2019 •
edited
Loading

Additional RN 0.61 changes, including switching to Hermes instead of the JSC for Android

Gutenberg side PR: WordPress/gutenberg#19369

WIP

To test:

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

hypest added 28 commits December 18, 2019 04:34
@hypest
Try to match a default RN 061 app
0a0cfee
@hypest
Some more updates
0a88d79
@hypest
Don't force resolve rn/cli
c808857
@hypest
Needs commas
f08eb6e
@hypest
Match the allowBackup value from WordPress-Aztec-Android:glide-loader
679de7b
@hypest
Using the Hermes binary
7dd0dfe
@hypest
Upgrade react-native-svg to 9.13.6-gb
c4873c9
@hypest
Replace the removed leftShift gradle operator
722e875
@hypest
Keep Hermes AARs around after node_modules cleanup, to use while buil…
ec6c216 
…ding android bridge
@hypest
Let's try building on JitPack without installing SDKs manually
403b858
@hypest
Log the Hermes state
3e6e104
@hypest
Set the Hermes executor factory. Not sure if really needed
e979814
@hypest
Upgrade react-native-video to 5.0.1
1282f76
@hypest
Bump the bridge RN dep to 0.61.5 too
20ccb07
@hypest
Remove some refs to JSC
300f8da
@hypest
Dep on Hermes only in the bridge lib
9be1794
@hypest
Use an env var in CircleCI cache key for remotecontrol
9fe679b
@hypest
Upgrade all locked package versions
7c2237a
@hypest
Revert "Upgrade all locked package versions"
ba322d2 
This reverts commit 7c2237a.
@hypest
Bump react-native-svg ref
a03777d
@hypest
Bump react-native-video ref
c745e8c
@hypest
Update Gutenberg ref from gb-mobile develop
8a41046
@hypest
Merge branch 'develop' into update-rn-0-61-and-inited-061-app
5a169bd
@hypest
Update yarn.lock
467c96d
@hypest
Try to bypass CI issue by pinning to an older lodash version
71f6d33 
CI errors with the following so far:
error https://registry.yarnpkg.com/lodash/-/lodash-4.17.15.tgz:
Extracting tar content of undefined failed, the file appears to be
corrupt: "ENOENT: no such file or directory, chmod
'/home/circleci/.cache/yarn/v6/npm-lodash-4.17.15-b447f6670a0455bbfeedd11392eff330ea097548-integrity/node_modules/lodash/fp/toNumber.js'"
@hypest
Revert "Try to bypass CI issue by pinning to an older lodash version"
d7af9d5 
This reverts commit 71f6d33.
@hypest
Match @babel/core version to v0.61.5's init app
aafff36
@hypest
Match @babel/runtime version to v0.61.5's init app
381ddf9
@hypest hypest mentioned this pull request Dec 24, 2019
Closed
2 tasks
@hypest hypest changed the title Update rn 0 61 and inited 061 app Update to RN 0.61, Hermes Dec 24, 2019
@hypest hypest mentioned this pull request Dec 30, 2019
Merged
6 tasks
This was referenced Dec 31, 2019
Closed
Closed
@SergioEstevao SergioEstevao self-requested a review January 9, 2020 15:57
@SergioEstevao SergioEstevao added the [Type] Enhancement Improves a current area of the editor label Jan 9, 2020
@SergioEstevao SergioEstevao marked this pull request as ready for review January 9, 2020 17:21
SergioEstevao
SergioEstevao approved these changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great on CI and locally! :shipit:

@SergioEstevao SergioEstevao merged commit df2f8d2 into update-rn-0-61 Jan 10, 2020
@SergioEstevao SergioEstevao deleted the update-rn-0-61-and-inited-061-app branch January 10, 2020 09:49
@hypest hypest mentioned this pull request Jan 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioEstevao SergioEstevao SergioEstevao approved these changes

Assignees
No one assigned
Labels
[Type] Enhancement Improves a current area of the editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hypest @SergioEstevao