Add mobile Spacer component #1436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
…rg-mobile into callstack/rnmobile/spacer
…rg-mobile into callstack/rnmobile/spacer
…rg-mobile into callstack/rnmobile/spacer
…rg-mobile into callstack/rnmobile/spacer
pinarol
reviewed
Nov 1, 2019
pinarol
reviewed
Nov 1, 2019
…rg-mobile into callstack/rnmobile/spacer
lukewalczak
force-pushed
the
callstack/rnmobile/spacer
branch
from
2c6d095 to
1d46e96
Compare
|
Could you add a sample spacer block into the demo content?(initial-html.js) |
@pinarol - There are two already. I guess they used to be hidden as “unsupported”. |
|
No need then, thanks for the heads up @etoledom :) let’s merge this anyway. gutenberg ref is prolly updated by another pr already but if we close this without merging then it can be misleading for the weekly reports. |
pinarol
approved these changes
Nov 7, 2019
…rg-mobile into callstack/rnmobile/spacer
|
👋, my impression is that the Spacer block is currently behind the DEV flag so, not visible to the end/production user. Can you confirm @lukewalczak and if that's the case, let's also update the PR description to note that fact, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1428
Ref to gutenberg PR: WordPress/gutenberg#17896
NOTE: Spacer block is currently behind the DEV flag so, it's not visible to the production user
To test: Instruction attached in gutenberg PR.
Update release notes:
RELEASE-NOTES.txt.