-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue/207 quotes design review #1067
Conversation
Thanks for jumping on those changes! Looking great. I just noticed something that I should've noticed in the first review. There appears to be a small gap on the left side of the Quote divider line. I'm unsure if this is because of something in this quote work, or related to this issue (I am also seeing this spacing on an Android build that @hypest just sent me). |
@iamthomasbishop sorted the margin issue, here is the end result: |
Very interesting optical illusion going on here. It looks like it's like 2-4px left of aligned, but mathematically it's "proper" :) It's easier to see it's aligned w/ an alignment guide, for example: But when you remove the guide, it optically feels slightly left of where it should be. For now, let's keep it simple and leave it how you have it right now – we can always adjust it if we want to align optically, but this sets it to the mathematical baseline. Thank you! |
Fixes #207
Related GB PR: WordPress/gutenberg#15990
This PR addresses the design review made in #207. It changes the following:
Here is the end result:
To test:
Update release notes:
RELEASE-NOTES.txt
.