Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List block #208

Closed
3 of 5 tasks
koke opened this issue Oct 29, 2018 · 9 comments
Closed
3 of 5 tasks

List block #208

koke opened this issue Oct 29, 2018 · 9 comments
Assignees
Labels
Milestone

Comments

@koke
Copy link
Member

koke commented Oct 29, 2018

Add support for the list block.

I don't know the difficulty of implementing the indent and outdent buttons, but I'd be fine leaving those out of the beta. I don't see anything else on the web version to leave out.

List-related issues:

Not blockers:

Strikethrough items are let to have a life of their own (see #208 (comment)).

@koke koke added this to the Beta milestone Oct 29, 2018
@koke
Copy link
Member Author

koke commented Nov 6, 2018

This was estimated at 1-2 weeks by @daniloercoli, but as @diegoreymendez pointed out, we were not accounting for nested lists. Hopefully those are easy, but they aren't as critical for the beta, so we'll count 2 weeks per platform for this task and re-evaluate when we know more

@hypest
Copy link
Contributor

hypest commented Apr 5, 2019

Known issues after #704:

Issue #845: caret positioning when new item at the end

  1. Do a long list, long enough to have a few empty list items here and there
  2. Try to add a new item at the end of the list
  3. Notice that the caret doesn't land on the new list item but rather, goes "back". The more empty lines from 2., the more chars the caret goes back.

Issue #846: Ordered list number indicators don't respect alignment when adding a new item to the end of the list

  1. Do a long list (> 10 items in the list)
  2. Try to add a new item at the end of the list
  3. Notice that number indicators < 10 don't respect alignment until you type something in the item
    list-android

Issue #836: Undo sometimes crashes on multi-line lists

  1. Create a new list
  2. Add a line
  3. Press enter and add another line
  4. Click undo

@koke
Copy link
Member Author

koke commented Apr 12, 2019

Let's keep this open until we have nested lists, and the implementation is solid enough to enable on production builds.

@koke koke reopened this Apr 12, 2019
@koke
Copy link
Member Author

koke commented Apr 16, 2019

To avoid cluttering the 2.0 Bugs column, I started a checklist on this issue with all the list-related bugs. Please keep adding there as you find them. When this is ready for production, let's make sure any remaining items have a card in the project

@iamthomasbishop
Copy link
Contributor

iamthomasbishop commented Apr 19, 2019

Just added my notes from a quick design review on the current (as of the current WPAndroid alpha) list block: #897

@mchowning
Copy link
Contributor

Added a minor issue related to caret positioning when splitting list items: #929

@koke koke modified the milestones: v1.2, v1.4 Apr 30, 2019
@hypest
Copy link
Contributor

hypest commented May 3, 2019

Bumping this to the next milestone.

@hypest hypest modified the milestones: v1.4, v1.5 May 3, 2019
@koke
Copy link
Member Author

koke commented May 3, 2019

Since we're shipping lists for both platforms in 1.4, and we have individual issues for every known bug, I think we can close this one?

@hypest
Copy link
Contributor

hypest commented May 6, 2019

Will strikethrough the non-checked items in the ticket and will leave the individual tickets to have a life of their own 👍 .

@hypest hypest closed this as completed May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants