Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename WordPressMedia to AsyncImageKit #23937

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

kean
Copy link
Contributor

@kean kean commented Jan 2, 2025

I picked a more generic name for a recently introduced WordPressMedia module – AsyncImageKit. The former name wasn't entirely accurate. No other changes.

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean merged commit cdfbd20 into christmas-feature-branch Jan 2, 2025
0 of 11 checks passed
kean added a commit that referenced this pull request Jan 2, 2025
@kean kean deleted the task/rename-wordpress-media branch January 2, 2025 21:57
@kean kean mentioned this pull request Jan 2, 2025
14 tasks
@dangermattic
Copy link
Collaborator

1 Error
🚫 PR requires at least one label.
2 Warnings
⚠️ Modules/Package.swift was changed without updating its corresponding Package.resolved. Please resolve the Swift packages as appropriate to your project setup (e.g. in Xcode or by running swift package resolve).
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23937-b9de1da
Version25.6
Bundle IDcom.jetpack.alpha
Commitb9de1da
App Center Buildjetpack-installable-builds #10290
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23937-b9de1da
Version25.6
Bundle IDorg.wordpress.alpha
Commitb9de1da
App Center BuildWPiOS - One-Offs #11254
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean changed the title Rename WordPressMedia Rename WordPressMedia to AsyncImageKit Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants