Fix an issue with blogging reminders prompt not being shown after publishing a new post #23930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kean
force-pushed
the
fix/blogging-reminders-prompt-flow
branch
from
c32185c to
57d2e02
Compare
kean
commented
Dec 30, 2024
| @@ -204,19 +204,18 @@ extension PublishingEditor { | |||
| } | |||
|
|
|||
| func discardUnsavedChangesAndUpdateGUI() { | |||
| let postDeleted = discardChanges() | |||
| dismissOrPopView(didSave: !postDeleted) | |||
| discardChanges() | |||
There was a problem hiding this comment.
The fact that we no longer need didSave simplified this quite a bit.
| comment: "Title of the set goals button in the Blogging Reminders Settings flow.") | ||
| private enum Strings { | ||
| static let introTitle = NSLocalizedString("bloggingRemindersPrompt.intro.title", value: "Blogging Reminders", comment: "Title of the Blogging Reminders Settings screen.") | ||
| static let introDescription = NSLocalizedString("bloggingRemindersPrompt.intro.details", value: "Set up your blogging reminders on days you want to post.", comment: "Description on the first screen of the Blogging Reminders Settings flow called aftet post publishing.") |
There was a problem hiding this comment.
There was no longer need for a separate path + I adopted l10n.
| // We need to grab the latest Post Reference, since it may have changed (ie. revision / user picked a | ||
| // new blog). | ||
| if changesSaved { | ||
| strongSelf.post = editor?.post as? Post |
There was a problem hiding this comment.
This is no longer how it works starting from 23.9. After publishing editor?.post as? Post points to a revision that gets deleted during publishing. self.post is sufficient now.
|
| App Name |  WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23930-57d2e02 | |
| Version | 25.6 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 57d2e02 | |
| App Center Build | WPiOS - One-Offs #11238 |
|
| App Name |  Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23930-57d2e02 | |
| Version | 25.6 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 57d2e02 | |
| App Center Build | jetpack-installable-builds #10276 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18696. I also updated the localization to no longer say "while the post is publishing..." – it's guaranteed to be published by this point.
To test:
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-12-30.at.17.55.39.mp4
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txtif necessary.Testing checklist: