Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Folders for Classes #23736

Merged
merged 4 commits into from
Oct 31, 2024
Merged

Use Folders for Classes #23736

merged 4 commits into from
Oct 31, 2024

Conversation

jkmassel
Copy link
Contributor

@jkmassel jkmassel commented Oct 31, 2024

Removes most of the code from the Xcode project file, instead using a folder.

This makes the file way smaller, should make Xcode way more responsive, and should mean we get far fewer conflicts in the project file.

Uses @mokagio's idea from #23679 to make it CocoaPods-compatible.

To Test:

  1. Ensure CI passes
  2. Ensure that running bundle exec pod install locally works

@dangermattic
Copy link
Collaborator

dangermattic commented Oct 31, 2024

2 Warnings
⚠️ This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
⚠️ This PR is assigned to the milestone 25.5. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@jkmassel jkmassel added this to the 25.5 milestone Oct 31, 2024
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Oct 31, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23736-a923946
Version25.4.2
Bundle IDorg.wordpress.alpha
Commita923946
App Center BuildWPiOS - One-Offs #10919
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Oct 31, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23736-a923946
Version25.4.2
Bundle IDcom.jetpack.alpha
Commita923946
App Center Buildjetpack-installable-builds #9959
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@jkmassel jkmassel marked this pull request as ready for review October 31, 2024 04:43
@jkmassel jkmassel enabled auto-merge October 31, 2024 04:43
Copy link
Contributor

@crazytonyli crazytonyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

Copy link
Contributor

@kean kean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@jkmassel jkmassel added this pull request to the merge queue Oct 31, 2024
Merged via the queue into trunk with commit f4da7f9 Oct 31, 2024
24 checks passed
@jkmassel jkmassel deleted the use/folders-for-classes branch October 31, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants