Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the first Stats tab a default one if there's none selected #23167

Merged
merged 2 commits into from
May 8, 2024

Conversation

staskus
Copy link
Contributor

@staskus staskus commented May 7, 2024

Fixes #

Make the first Stats tab a default one if there's none selected.

The issue with the current code is that user defaults return 0 even if integer value doesn't exist. 0 is the raw value of Insights tab.

To test:

Feature flag enabled

  1. Fresh install Jetpack app
  2. Enable Stats Subscribers and Traffic tab feature flag
  3. Open Stats
  4. Confirm Traffic is selected by default
  5. Change to Subscribers
  6. Leave and come back
  7. Confirm Subscribers is selected

Feature flag disabled

  1. Fresh install Jetpack app
  2. Disable Stats Subscribers and Traffic tab feature flag
  3. Open Stats
  4. Confirm Insights is selected by default
  5. Change to Years
  6. Leave and come back
  7. Confirm Years is selected

Regression Notes

  1. Potential unintended areas of impact

None

  1. What I did to test those areas of impact (or what existing automated tests I relied on)

  2. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@staskus staskus added this to the 24.9 milestone May 7, 2024
@staskus staskus requested a review from guarani May 7, 2024 08:19
@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 7, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23167-43973c0
Version24.8
Bundle IDorg.wordpress.alpha
Commit43973c0
App Center BuildWPiOS - One-Offs #9830
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 7, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23167-43973c0
Version24.8
Bundle IDcom.jetpack.alpha
Commit43973c0
App Center Buildjetpack-installable-builds #8878
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @staskus! Looks good, left a nitpick.

Co-authored-by: Paul Von Schrottky <paul.von.schrottky@automattic.com>
@staskus staskus merged commit aed7414 into trunk May 8, 2024
24 checks passed
@staskus staskus deleted the fix/stats-subscribers-fixes branch May 8, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants