Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notifications Refresh] Improve comment moderation views transition smoothness #23157

Merged
merged 5 commits into from
May 9, 2024
Merged

[Notifications Refresh] Improve comment moderation views transition smoothness #23157

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ff8802c
Improve comment moderation sheet transition smoothness
salimbraksa May 5, 2024
d1ed21d
Decrease insertion animation delay
salimbraksa May 5, 2024
eccb016
Fix a minor typo
salimbraksa May 5, 2024
8213bfd
Fix lint issue
salimbraksa May 5, 2024
fc2c176
Define transition and animation delay as constants
salimbraksa May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions WordPress/Classes/ViewRelated/Notifications/Comment Moderation/CommentModerationState.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
enum CommentModerationState: CaseIterable {
enum CommentModerationState: Equatable {
case pending
case approved
case liked
case approved(liked: Bool)
case spam
case trash
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I removed the liked case as it seems more like a substate of the approved state rather than a distinct state within the moderation view.
  2. I added the spam state.

}
Loading