Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats: Create missing ghost (loading) views #23146

Merged
merged 13 commits into from
May 6, 2024

Conversation

staskus
Copy link
Contributor

@staskus staskus commented May 3, 2024

Fixes #23059

Created missing ghost loading views:

  • For 3-column cell
  • For a single value cell
  • For a line chart

Solution

We use Ghostable extension implemented in WordPressSharedUI which animates the top leaf views.

  • Improved StatsGhostTopCell to support dynamic input of the "number of columns".
  • Added StatsGhostSingleValueCell to support ghost loading of single value cells, such as Total Subscribers
  • Created StatsGhostLineChartCell to create a dummy line chart path and mask ghostable layer
RPReplay_Final1714735717.MP4

To test:

For easier testing, set a slow Network Link Conditioner setting.

  1. Open Stats -> Subscribers
  2. Observe new ghostable loading views:
  • Single value for Total Subscribers
  • Line chart for Subsribers chart
  • 2 columns for Subscribers list
  • 3 columns for Emails
  1. Change orientation and switch between dark/light mode and confirm the view adapts

Regression Notes

  1. Potential unintended areas of impact

Places that use StatsGhostTopCell should continue working as before, since I set 2 column scenario as default

  1. What I did to test those areas of impact (or what existing automated tests I relied on)

Manual testing

  1. What automated tests I added (or what prevented me from doing so)

None

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@staskus staskus added this to the 24.9 milestone May 3, 2024
@staskus staskus requested a review from guarani May 3, 2024 11:43
@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 3, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23146-edd95a6
Version24.8
Bundle IDcom.jetpack.alpha
Commitedd95a6
App Center Buildjetpack-installable-builds #8829
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 3, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23146-edd95a6
Version24.8
Bundle IDorg.wordpress.alpha
Commitedd95a6
App Center BuildWPiOS - One-Offs #9783
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@osullivanchris
Copy link

Looks cool!

Copy link
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works very well! Thanks for handling all the loading views.

I left some minor comments, feel free to merge as-is.

@staskus staskus enabled auto-merge May 6, 2024 08:35
@staskus staskus merged commit fd795d8 into trunk May 6, 2024
19 of 24 checks passed
@staskus staskus deleted the task/23059-stats-create-missing-ghost-views branch May 6, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stats: Create missing ghost (loading) views
4 participants