Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gutenberg] Test persisting local media files when uploading images #22409

Closed
wants to merge 14 commits into from

Conversation

derekblank
Copy link
Contributor

Test build to persist local media file without flicker between downloading a server image asset.

Related:

Fixes:

To test:
TBD

Regression Notes

  1. Potential unintended areas of impact
    TBD

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    TBD

  3. What automated tests I added (or what prevented me from doing so)
    TBD

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@derekblank derekblank added [Type] Enhancement [Status] DO NOT MERGE Gutenberg Editing and display of Gutenberg blocks. labels Jan 17, 2024
@derekblank derekblank self-assigned this Jan 17, 2024
@dangermattic
Copy link
Collaborator

1 Error
🚫 This PR is tagged with [Status] DO NOT MERGE label(s).

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 18, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr22409-8abdd17
Version24.0
Bundle IDorg.wordpress.alpha
Commit8abdd17
App Center BuildWPiOS - One-Offs #8608
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 18, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr22409-8abdd17
Version24.0
Bundle IDcom.jetpack.alpha
Commit8abdd17
App Center Buildjetpack-installable-builds #7637
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@derekblank
Copy link
Contributor Author

derekblank commented Jan 25, 2024

Regression Testing

Device: iPhone SE
Build: pr22409-73ce4d2

Image

  • Image block - Insert image from device (failing) - TC001
  • Image block - Insert image from device (cancel) - TC002
  • Image block - Add Caption - TC003
  • Image block - Close/Re-open post with an ongoing image upload - TC004
  • Image block - Close post with an ongoing image upload - TC005
  • Image block - Border style setting - TC006
  • Image block - Image size setting - TC007

Gallery

  • Gallery block - Close/Re-open post with an ongoing image upload - TC001
  • Gallery block - Close post with an ongoing image upload - TC002
  • Gallery block - Choose from device (stay in editor) - Successful upload TC005
  • Gallery block - Insert image from device (failing) - TC006
  • Gallery block - Take a photo - TC007
  • Gallery block - Choose from the free photo library TC008
  • Gallery block - Insert image from device (cancel) - TC009
  • Gallery block - Columns - TC0013
  • Gallery block - Crop images - TC0014

MediaText

  • Media Text block - Insert image from device (failing) - TC001
  • Media Text block - Close/Re-open post with an ongoing image upload - TC003
  • Media Text block - Insert video from device - TC002-v
  • Media Text block - Insert image from device - TC002-i

MultipleUpload

  • Simultaneous uploads - TC001

Cover

  • Cover - Add image background from WordPress Media library - TC001
  • Cover - Image focal point is rendered properly - TC002
  • Cover - Custom color is rendered properly - TC002

Note: A minor regression was identified in the Cover and Media-Text blocks where the network image would not display in the Editor unless the Editor was closed and re-opened. This was fixed by the commit WordPress/gutenberg@70b003a and the regression disappeared.

@derekblank
Copy link
Contributor Author

Closing, no longer needed.

@derekblank derekblank closed this Jan 31, 2024
@jkmassel jkmassel deleted the gutenberg/test-image-uploads branch July 26, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks. [Status] DO NOT MERGE [Type] Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants