Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use raw value for the quality parameter in app_settings_image_quality_changed event #22396

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Jan 15, 2024

This PR updates the value sent in the quality property of the event app_settings_image_quality_changed introduced in #21981. The reason for the change is that the value currently sent is localized:

Screenshot 2024-01-15 at 18 14 01

To test:

  1. Navigate to the Me screen.
  2. Tap on App Settings button.
  3. Tap on the Image Quality button.
  4. Change the quality setting.
  5. Navigate back.
  6. Observe that the event app_settings_image_quality_changed is generated with the proper quality value.

The values are mapped with the following strings:

case maximum = "MaximumQuality100"
case high = "HighQuality90"
case medium = "MediumQuality80"
case low = "LowQuality70"

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jan 15, 2024

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@fluiddot fluiddot added this to the 24.0 ❄️ milestone Jan 15, 2024
@fluiddot fluiddot requested review from twstokes and SiobhyB January 15, 2024 17:28
@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr22396-a7eff63
Version24.0
Bundle IDcom.jetpack.alpha
Commita7eff63
App Center Buildjetpack-installable-builds #7466
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr22396-a7eff63
Version24.0
Bundle IDorg.wordpress.alpha
Commita7eff63
App Center BuildWPiOS - One-Offs #8443
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@SiobhyB SiobhyB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching this, @fluiddot! A TIL moment for me, I hadn't previously considered the need to prevent localisation for events. I tested this change and confirmed the event is no longer localised. 🙇‍♀️

@fluiddot fluiddot merged commit f7204f1 into release/24.0 Jan 16, 2024
19 of 21 checks passed
@fluiddot fluiddot deleted the fix-event-image-quality-changed-value branch January 16, 2024 09:49
@fluiddot fluiddot self-assigned this Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants