Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the MediaThumbnailService #22106

Merged
merged 5 commits into from
Nov 28, 2023
Merged

Remove the MediaThumbnailService #22106

merged 5 commits into from
Nov 28, 2023

Conversation

kean
Copy link
Contributor

@kean kean commented Nov 28, 2023

The PR #22042 (23.8) introduced the .medium size of the thumbnails for use by the Site Media screen, but this change is incomplete without removing the remaining usage of MediaThumbnailService in MediaImportService to pre-generate thumbnails for the use by the editor.

This PR removes the last use of the deprecated MediaThumbnailService and replaces with a new service. The thumbnails are slightly smaller than created by MediaThumbnailService to reduce the disk space usage, in the same vein as #21981.

To test:

  • Verify that the editor displays an image placeholder during the upload

Regression Notes

  1. Potential unintended areas of impact: Editor
  2. What I did to test those areas of impact (or what existing automated tests I relied on): manual
  3. What automated tests I added (or what prevented me from doing so): n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean force-pushed the fix/unnecessary-thumbnails branch from d9cdcb7 to 0b1a6c0 Compare November 28, 2023 12:32
@kean kean changed the base branch from release/23.8 to trunk November 28, 2023 12:33
@kean kean changed the title Remove the MediaThumbnailService usage for media imports Remove the MediaThumbnailService Nov 28, 2023
@kean kean changed the base branch from trunk to task/remove-wpmideapicker November 28, 2023 12:33
@kean kean force-pushed the fix/unnecessary-thumbnails branch from 0b1a6c0 to b061836 Compare November 28, 2023 12:35
@kean kean requested a review from momo-ozawa November 28, 2023 12:36
@kean kean added this to the 23.9 milestone Nov 28, 2023
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Nov 28, 2023

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr22106-2693a99
Version23.8
Bundle IDorg.wordpress.alpha
Commit2693a99
App Center BuildWPiOS - One-Offs #7984
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Nov 28, 2023

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr22106-2693a99
Version23.8
Bundle IDcom.jetpack.alpha
Commit2693a99
App Center Buildjetpack-installable-builds #7008
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Co-authored-by: Momo Ozawa <momo-ozawa@users.noreply.github.com>
Base automatically changed from task/remove-wpmideapicker to trunk November 28, 2023 15:30
@wpmobilebot
Copy link
Contributor

1 Warning
⚠️ View files have been modified, but no screenshot is included in the pull request. Consider adding some for clarity.

Generated by 🚫 Danger

@kean kean merged commit afbf797 into trunk Nov 28, 2023
@kean kean deleted the fix/unnecessary-thumbnails branch November 28, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants