-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the MediaThumbnailService #22106
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kean
force-pushed
the
fix/unnecessary-thumbnails
branch
from
November 28, 2023 12:32
d9cdcb7
to
0b1a6c0
Compare
kean
changed the title
Remove the MediaThumbnailService usage for media imports
Remove the MediaThumbnailService
Nov 28, 2023
kean
force-pushed
the
fix/unnecessary-thumbnails
branch
from
November 28, 2023 12:35
0b1a6c0
to
b061836
Compare
📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
|
momo-ozawa
approved these changes
Nov 28, 2023
Co-authored-by: Momo Ozawa <momo-ozawa@users.noreply.github.com>
Generated by 🚫 Danger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR #22042 (23.8) introduced the
.medium
size of the thumbnails for use by the Site Media screen, but this change is incomplete without removing the remaining usage ofMediaThumbnailService
inMediaImportService
to pre-generate thumbnails for the use by the editor.This PR removes the last use of the deprecated
MediaThumbnailService
and replaces with a new service. The thumbnails are slightly smaller than created byMediaThumbnailService
to reduce the disk space usage, in the same vein as #21981.To test:
Regression Notes
PR submission checklist:
RELEASE-NOTES.txt
if necessary.UI Changes testing checklist: