Add UI tests of image optimization setting

[fluiddot]

This PR is a follow-up of #21981 and adds UI tests of the new App Setting to optimize images when uploading.

To test:
N/A

Regression Notes

1. Potential unintended areas of impact
   N/A

2. What I did to test those areas of impact (or what existing automated tests I relied on)
   N/A

3. What automated tests I added (or what prevented me from doing so)
   N/A

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding unit tests for my changes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

• Portrait and landscape orientations.
• Light and dark modes.
• Fonts: Larger, smaller and bold text.
• High contrast.
• VoiceOver.
• Languages with large words or with letters/accents not frequently used in English.
• Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
• iPhone and iPad.
• Multi-tasking: Split view and Slide over. (iPad)

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.

	App Name	WordPress Alpha
	Configuration	Release-Alpha
	Build Number	pr22095-ac3d4d4
	Version	23.7
	Bundle ID	org.wordpress.alpha
	Commit	ac3d4d4
	App Center Build	WPiOS - One-Offs #7979

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.

	App Name	Jetpack Alpha
	Configuration	Release-Alpha
	Build Number	pr22095-ac3d4d4
	Version	23.7
	Bundle ID	com.jetpack.alpha
	Commit	ac3d4d4
	App Center Build	jetpack-installable-builds #7003

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[fluiddot]

I noticed that the Delete app button wasn't tapped when running the UI tests locally. For this reason, I decided to change this action to explicitly wait for the element's existence.

[twstokes]

Nice @fluiddot! Thanks for going the extra mile to add these.

[pachlava]

@fluiddot 👋

Just leaving a note that I'm looking into a PR — will leave some feedback today a bit later. Thank you for adding the tests! 👍

[pachlava]

@fluiddot 👋

Thank you so much for adding the UI tests, and extending the Screens to support "App Settings" screen ⭐

I executed the tests locally for iPhone with no issues 👍 , and left two minor naming / formatting comments, they're not blocking.

P.S. One thing to discuss (@jostnes and @tiagomar 👋): since we try to have mainly critical flows automated, should we consider splitting the tests schemes to Smoke and Full, to keep the execution time under 30 minutes for Smoke? With Xcode 15 incoming, this might become problematic if we keep on running all tests on every push.

[pachlava]

At first, I was confused why this file uses removeBeforeLaunching, but then I realized that this is to ensure that Image Optimization prompt is shown for both testImageOptimizationIsTurnedOnEditor and testImageOptimizationIsTurnedOffEditor, and that tests in this file are independent/isolated.

We might need to keep this in mind, though, if we add more tests into this file: for other tests deleting the app might not be necessary, but it takes quite a lot of time.

[fluiddot]

At first, I was confused why this file uses removeBeforeLaunching, but then I realized that this is to ensure that Image Optimization prompt is shown for both testImageOptimizationIsTurnedOnEditor and testImageOptimizationIsTurnedOffEditor, and that tests in this file are independent/isolated.

Yeah, I should have added a note here explaining why it's necessary to remove it before launching. I'll add an inline comment as a follow-up.

We might need to keep this in mind, though, if we add more tests into this file: for other tests deleting the app might not be necessary, but it takes quite a lot of time.

I agree. This approach is specific to the tests I added. In the future, it's likely to be unnecessary for other tests related to the App Settings screen. I wonder if there's an option to enable removeBeforeLaunching at the test level. If not, we can consider renaming the test file to OptimizeImagesSettingTests to convey that the file should only include test cases related to that logic.

[pachlava]

I wonder if there's an option to enable removeBeforeLaunching at the test level

Maybe not the nicest way, but this should do the trick (not tested):

let testsRequiringAppDeletion = [
        "testImageOptimizationEnabledByDefault",
        "testImageOptimizationIsTurnedOnEditor",
        "testImageOptimizationIsTurnedOffEditor"
    ]

let removeBeforeLaunch = testsRequiringAppDeletion.contains(where: { testName in self.name.contains(testName)})

try super.setUpWithError()
setUpTestSuite(removeBeforeLaunching: removeBeforeLaunch)

[fluiddot]

I tried your approach and it worked nice, thanks for sharing it. I haven't found another approach to use a different setup depending on the test case, so I think we can apply this workaround. Applied in 00e4d46.