Blaze: Show Blaze in general section #20314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
You can test the changes in WordPress from this Pull Request by:
|
hassaanelgarem
approved these changes
Mar 13, 2023
Comment on lines
878
to
888
| CGSize iconSize = CGSizeMake(BlogDetailGridiconSize, BlogDetailGridiconSize); | ||
| UIImage *blazeIcon = [[UIImage imageNamed:@"icon-blaze"] resizedImage:iconSize interpolationQuality:kCGInterpolationHigh]; | ||
| BlogDetailsRow *blazeRow = [[BlogDetailsRow alloc] initWithTitle:NSLocalizedString(@"Blaze", @"Noun. Links to a blog's Blaze screen.") | ||
| accessibilityIdentifier:@"Blaze Row" | ||
| image:[blazeIcon imageFlippedForRightToLeftLayoutDirection] | ||
| imageColor:nil | ||
| renderingMode:UIImageRenderingModeAlwaysOriginal | ||
| callback:^{ | ||
| [weakSelf showBlaze]; | ||
| }]; | ||
| blazeRow.showsSelectionState = NO; |
There was a problem hiding this comment.
[Nit] What do you think of extracting this to a helper that creates a Blaze row to avoid code duplication?
You can test the changes in Jetpack from this Pull Request by:
|
|
FYI @mokagio 🙇♀️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Shows the Blaze menu item in the general section. The general section is shown if the jetpack section isn't shown.
Note
The base branch for this PR will automatically update to
release/21.9once #20290 gets merged intorelease/21.9How to test
Regression Notes
Potential unintended areas of impact
n/a
What I did to test those areas of impact (or what existing automated tests I relied on)
n/a
What automated tests I added (or what prevented me from doing so)
n/a
PR submission checklist:
RELEASE-NOTES.txtif necessary.