Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stats: fix Period Authors details expanded row height #12191

Merged
merged 3 commits into from
Jul 24, 2019
Merged

Stats: fix Period Authors details expanded row height #12191

merged 3 commits into from
Jul 24, 2019

Conversation

ScoutHarris
Copy link
Contributor

Fixes #11824

To test:

  • Go to Period > Authors > View more.
  • Expand an Author.
  • Verify the child row height is approximately 44pt high (the rows are dynamic, but it should be close).

author_details_child_rows

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@ScoutHarris ScoutHarris added this to the 13.0 milestone Jul 23, 2019
@ScoutHarris ScoutHarris requested a review from danielebogo July 23, 2019 22:22
@ScoutHarris ScoutHarris self-assigned this Jul 23, 2019
danielebogo
danielebogo approved these changes Jul 24, 2019
View reviewed changes
Copy link
Contributor

@danielebogo danielebogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@ScoutHarris ScoutHarris merged commit 5db6f5e into develop Jul 24, 2019
@ScoutHarris ScoutHarris deleted the fix/11824-authors_detail_row_height branch July 24, 2019 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielebogo danielebogo danielebogo approved these changes

Assignees

@ScoutHarris ScoutHarris

Labels
None yet
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.

[Stats Refresh] Period Authors details: expanded rows should be 44pt
2 participants
@ScoutHarris @danielebogo