[Stats Refresh] remove extra space when 'No data' shown #11813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 tasks
danielebogo
requested changes
May 30, 2019
There was a problem hiding this comment.
Hey @ScoutHarris ! Thanks for fixing this!
I left 2 small comments. Let me know when it's done so I'll give it another look!
WordPress/Classes/ViewRelated/Stats/Period Stats/Countries/CountriesCell.swift
Outdated
Show resolved
Hide resolved
|
Hey @danielebogo . Thanks for catching those. They've been fixed, and ready for another review please. |
danielebogo
approved these changes
May 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11798
The problem stemmed from toggling two top constraints on the row stack view depending on if the subtitles are shown or not. This wasn't working very well when the cells were reused. Now there is only one top constraint, and is modified per subtitle visibility.
To test:
No data...is displayed there is no longer extra space above the label. Example:No data...verify the subtitles are shown correctly. Example:Update release notes:
RELEASE-NOTES.txt.