Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stats Refresh] Insights tabbed cards: fix displaying details view #11675

Merged
merged 2 commits into from
May 13, 2019

Conversation

ScoutHarris
Copy link
Contributor

Ref #11360

This changes the Insights tabbed cards, Comments and Followers, to use UITableViewCells instead of one UIStackView.

Previously, all the data was stuffed into the stack view on the TabbedTotalsCell card. Now it only uses the TabbedTotalsCell card to show the header via the new DetailSubtitlesTabbedHeaderRow. The stack view is left empty. Instead, a UITableViewCell is added to the table for each data row via DetailDataRow.

There should be no visual or functional changes, but showing the details view is a lot faster. To note, there is still no loading view, so there may still be a blank view for a couple seconds for longer periods.

To test:


  • Go to Stats > Insights > Comments on a very active site.
  • Select View more.
  • Verify the data appears relatively quickly.
  • Verify selecting an Author row does nothing.
  • Verify selecting a Post/Page row shows a web view.
  • Verify selecting the filter tabs updates the data accordingly.

comments


  • Go to Stats > Insights > Followers on a very active site.
  • Select View more.
  • Verify the data appears relatively quickly.
  • Verify selecting a row does nothing.
  • Verify selecting the filter tabs updates the data accordingly.

followers


Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

…dating TabbedTotalsCell for displaying on details view.
…eaderRow, and add a DetailDataRow for each data row.
@ScoutHarris ScoutHarris added this to the 12.5 milestone May 10, 2019
@ScoutHarris ScoutHarris requested a review from danielebogo May 10, 2019 21:48
@ScoutHarris ScoutHarris self-assigned this May 10, 2019
@ScoutHarris ScoutHarris mentioned this pull request May 10, 2019
45 tasks
Copy link
Contributor

@danielebogo danielebogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ScoutHarris ! Everything looks good and works perfectly!
Well done!
:shipit:

@ScoutHarris ScoutHarris changed the base branch from fix/11360-countries_detail_view to develop May 13, 2019 19:07
@ScoutHarris ScoutHarris merged commit 6a27d25 into develop May 13, 2019
@ScoutHarris ScoutHarris deleted the fix/11360-tabbed_detail_views branch May 13, 2019 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants