Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stats Refresh] Period Posts and Pages: fix displaying details view #11660

Merged
merged 4 commits into from
May 9, 2019

Conversation

ScoutHarris
Copy link
Contributor

@ScoutHarris ScoutHarris commented May 9, 2019

Ref #11360

This is the first step in fixing #11360. Which is - instead of adding all the data to one UIStackView, use UITableViewCells instead. This change fixes Period > Posts and Pages in that manner.

Previously, all the data was stuffed into the stack view on the TopTotalsCell card. Which didn't work out so well with a lot of data.

Now it only uses the TopTotalsCell card to show the "header" via the new DetailSubtitlesHeaderRow. The stack view is left empty. Instead, a UITableViewCell is added to the table for each data row via the new DetailDataRow.

There should be no visual or functional changes, but showing the details view is a lot faster. To note, there is still no loading view, so there may still be a blank view for a couple seconds for longer periods.

Side note: The constraint warnings are not to do with the details view, but are from the Reader and News Card, and are present on develop as well.

To test:

  • Go to Stats > Period > Posts and Pages on a very active site (like en.blog or Hogwarts).
  • Select View more.
  • Verify the data appears relatively quickly.
  • Verify selecting a row displays the Post Stats view.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

pandp_details

Copy link
Contributor

@danielebogo danielebogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It worked as expected!
:shipit:

@ScoutHarris ScoutHarris merged commit 7d70bf4 into develop May 9, 2019
@ScoutHarris ScoutHarris deleted the fix/11360-posts_detail_view branch May 9, 2019 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants