[Stats Refresh] Period Posts and Pages: fix displaying details view #11660
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #11360
This is the first step in fixing #11360. Which is - instead of adding all the data to one
UIStackView
, useUITableViewCell
s instead. This change fixes Period > Posts and Pages in that manner.Previously, all the data was stuffed into the stack view on the
TopTotalsCell
card. Which didn't work out so well with a lot of data.Now it only uses the
TopTotalsCell
card to show the "header" via the newDetailSubtitlesHeaderRow
. The stack view is left empty. Instead, aUITableViewCell
is added to the table for each data row via the newDetailDataRow
.There should be no visual or functional changes, but showing the details view is a lot faster. To note, there is still no loading view, so there may still be a blank view for a couple seconds for longer periods.
Side note: The constraint warnings are not to do with the details view, but are from the Reader and News Card, and are present on
develop
as well.To test:
View more
.Update release notes:
RELEASE-NOTES.txt
.