[Stats Refresh] Insights Tags and Categories: add drop-down rows for groups #10944

ScoutHarris · 2019-02-04T20:19:55Z

Fixes #10832

To test:

On a site that has a post with multiple tags/categories:

Tip: Hogwarts usually has some.
Go to Stats > Insights > Tags and Categories.
Verify:
- The icon is folderMultiple.
- The disclosure icon is pointed down.

Click on a row that has multiple tags/categories.

Verify:
- Individual rows appear for each tag/category.
  - Max of 10 "child" rows will be displayed.
  - NOTE: we don't currently have the totals for expanded rows. Ref Insights Tags and Categories: show totals for expanded rows #10945.
- On the "parent" row, the disclosure icon is pointed up.
- The row dividers above and below the expanded section are the full width of the row.
- Selecting a "child" row displays a webview for that tag/category.

Verify expanded rows persist on scrolling and rotation.
Verify expanded rows are reset when Insights is first displayed.

…egate when parent row is selected.

…he row. Showing those when children rows are added.

…k view on the row to facilitate easy removal when the row is collapsed.

…s not do that.

…Also, be sure the row has children before rotating the disclosure icon.

…s are expanded.

…d rows according to row.expanded state.

…ately.

Plus some comments.

ScoutHarris · 2019-02-04T20:43:37Z

@SylvesterWilmott -

ScoutHarris · 2019-02-05T19:25:37Z

@jklausa this is causing constraint warnings when going from Insights > Period > Insights. I'll address those in the next PR, which is branched from this one.

Update: I checked develop. The constraint warnings are there too. So I broke it long before this PR. I'll address it separately.

SylvesterWilmott · 2019-02-06T13:22:48Z

This looks great @ScoutHarris !

I'm a little concerned by the jumpiness of the expanding/collapsing. In the .gif it appears that the cells above the one that expands/collapses is moving too which makes it a little difficult to follow what is happening. Is there a way to keep the other cells completely static and animate only the group that is expanding?

ScoutHarris · 2019-02-06T19:33:31Z

Hey @SylvesterWilmott .

jumpiness of the expanding/collapsing

Hrm. That's being caused by the need to redraw the card to resize it to accommodate adding/removing rows. Without the redraw, the rows were just smushed into the original card size. I'm not sure how else I can accomplish that. Do you mind if I add this to my todo list for later so can experiment and hopefully come up with a better solution?

jklausa

I have one request for some comments, but other than that — looks good!

jklausa · 2019-02-07T11:44:01Z

WordPress/Classes/ViewRelated/Stats/Insights/SiteStatsInsightsTableViewController.swift

+    }
+
+    func expandedRowUpdated(_ row: StatsTotalRow) {
+        applyTableUpdates()


Would you mind adding a comment why this is done this way here, instead of beginUpdates() at the beginning of this method and endUpdates() at the end?

Sure, I can. But for here - everything after applyTableUpdates is just updating an array that has no effect on the table. So I didn't think waiting to endUpdates was necessary.

jklausa · 2019-02-07T12:02:28Z

I also had similar issues with jumpiness in Plugins Detail view — I think I fought with it for a long time, and didn't manage to fix it a 100% (though I have an idea how to do it now...), but maybe you could take a peek there for inspiration :P

ScoutHarris · 2019-02-07T16:49:22Z

maybe you could take a peek there for inspiration

@jklausa thank you!

ScoutHarris added 23 commits January 29, 2019 17:00

Adding delegate method for expandedCellUpdated.

01d9232

Adding child rows property to StatsTotalRow, calling StatsTotalRowDel…

9874f01

…egate when parent row is selected.

Add child rows to stack view.

8fb1535

Add child rows to Tags and Categories rows.

c976c62

Merge branch 'develop' into feature/10832-insights_tandc_dropdown_rows

e810cbf

Toggle separator lines when child rows added.

2fbab83

Merge branch 'develop' into feature/10832-insights_tandc_dropdown_rows

0c6edd4

Adding top and bottom separator lines that extend the full width of t…

dc74d1a

…he row. Showing those when children rows are added.

Limit the number of child rows displayed.

ce3f3b7

Rotate the disclosure icon for rows with children.

6f42e50

Add child rows to the view via a separate stack view. Store that stac…

bc2cf14

…k view on the row to facilitate easy removal when the row is collapsed.

Having the animator as a lazy var caused a crash when scrolling. Let’…

451660c

…s not do that.

Moving disclosure rotation values to Constants struct.

82dc2fc

Fixing crash when scrolling & trying to animate the disclosure icon. …

923ade7

…Also, be sure the row has children before rotating the disclosure icon.

Merge branch 'develop' into feature/10832-insights_tandc_dropdown_rows

530634f

Adding a expandedRowLabels array. Use that to keep track of which row…

401895a

…s are expanded.

Set expanded state on data row.

6af9a40

When creating the cell, after the data rows are added, show/hide chil…

97c6b39

…d rows according to row.expanded state.

Store expanded rows by StatType, so they can be accessed/purged separ…

cf83df1

…ately.

Only initChildRows if the row actually has children.

1ea15fd

Merge branch 'develop' into feature/10832-insights_tandc_dropdown_rows

3c228fa

Clearing expanded rows on refresh.

b1a9060

Fix issue where expanded rows were being reset on iPhone+ rotation.

6a73e89

Plus some comments.

ScoutHarris added the Stats Refresh label Feb 4, 2019

ScoutHarris added this to the 11.8 milestone Feb 4, 2019

ScoutHarris self-assigned this Feb 4, 2019

ScoutHarris requested a review from jklausa February 4, 2019 20:19

ScoutHarris mentioned this pull request Feb 4, 2019

Stats Refresh Master Issue #10840

Closed

45 tasks

Merge branch 'develop' into feature/10832-insights_tandc_dropdown_rows

53ddb74

ScoutHarris mentioned this pull request Feb 6, 2019

[Stats Refresh] Add Period > Authors card #10953

Merged

Merge branch 'develop' into feature/10832-insights_tandc_dropdown_rows

e54c49b

jklausa approved these changes Feb 7, 2019

View reviewed changes

Merge branch 'develop' into feature/10832-insights_tandc_dropdown_rows

580e5f3

Adding a comment.

8c9757e

ScoutHarris merged commit b2a814b into develop Feb 7, 2019

ScoutHarris deleted the feature/10832-insights_tandc_dropdown_rows branch February 11, 2019 21:18

ScoutHarris mentioned this pull request Jun 4, 2019

Stats Refresh v2 Master Issue #11852

Closed

79 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Stats Refresh] Insights Tags and Categories: add drop-down rows for groups #10944

[Stats Refresh] Insights Tags and Categories: add drop-down rows for groups #10944

ScoutHarris commented Feb 4, 2019 •

edited

Loading

ScoutHarris commented Feb 4, 2019 •

edited

Loading

ScoutHarris commented Feb 5, 2019 •

edited

Loading

SylvesterWilmott commented Feb 6, 2019

ScoutHarris commented Feb 6, 2019

jklausa left a comment

jklausa Feb 7, 2019

ScoutHarris Feb 7, 2019

jklausa commented Feb 7, 2019

ScoutHarris commented Feb 7, 2019

[Stats Refresh] Insights Tags and Categories: add drop-down rows for groups #10944

[Stats Refresh] Insights Tags and Categories: add drop-down rows for groups #10944

Conversation

ScoutHarris commented Feb 4, 2019 • edited Loading

ScoutHarris commented Feb 4, 2019 • edited Loading

ScoutHarris commented Feb 5, 2019 • edited Loading

SylvesterWilmott commented Feb 6, 2019

ScoutHarris commented Feb 6, 2019

jklausa left a comment

Choose a reason for hiding this comment

jklausa Feb 7, 2019

Choose a reason for hiding this comment

ScoutHarris Feb 7, 2019

Choose a reason for hiding this comment

jklausa commented Feb 7, 2019

ScoutHarris commented Feb 7, 2019

ScoutHarris commented Feb 4, 2019 •

edited

Loading

ScoutHarris commented Feb 4, 2019 •

edited

Loading

ScoutHarris commented Feb 5, 2019 •

edited

Loading