[Stats Refresh] Hide/show navigation bar when scrolling #10852
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jklausa - please ignore this for now. Problems have been unearthed! |
|
Closing this PR. I'm not sure what the problem is, but I'll come back to it when I have a DWMY controller to actually test with. (aka I jumped the gun.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the Filter Tab Bar from the master Dashboard view, and adds it to the tableHeaderView of the table being displayed (Insights or DWMY).
NOTE: Since DWMY doesn't exist yet, if one of those filters is selected the Filter Tab Bar isn't displayed as there is no header to add it to.
To test: