[Deps] Add Back EventBus Android Dependency #153
Merged
+10
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This dependency was incorrectly removed and replaced by its corresponding 'eventbus-java' transitive dependency, assuming that is not required. However, after further testing it was revealed that this parent 'eventbus' dependency, which is actually 'android' specific is indeed necessary. If it is not provided on the classpath then an app will crash with the below runtime exception: ------------------------------------------------------------------------ java.lang.RuntimeException: Unable to create application xyz: java.lang .RuntimeException: It looks like you are using EventBus on Android, make sure to add the "eventbus" Android library to your dependencies. ------------------------------------------------------------------------ For more info see: - EventBus.register(...): https://github.com/greenrobot/EventBus/blob/ 0194926b3bcf70cc0d7bfd3c5da16708dd5ab876/EventBus/src/org/greenrobot/ eventbus/EventBus.java#L143-L147 - !AndroidDependenciesDetector.areAndroidComponentsAvailable(): https://github.com/greenrobot/EventBus/blob/ 0194926b3bcf70cc0d7bfd3c5da16708dd5ab876/EventBus/src/org/greenrobot/ eventbus/android/AndroidDependenciesDetector.java#L25-L36
wzieba
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds back the main
EventBusdependency, which isAndroidrelated.This dependency was incorrectly removed and replaced by its corresponding
eventbus-javatransitive dependency, assuming that is not required. However, after further testing it was revealed that this parenteventbusdependency, which is actuallyandroidspecific is indeed necessary. If it is not provided on the classpath then an app will crash with the below runtime exception:For more info see:
Testing Instructions
./gradlew buildHealthtask and verify that there is nounusedrelated advise related toeventbus.Utils, or via composite builds, and see if it works as expected.