Fallback to original URL if the beginIndex is invalid #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
mkevins
reviewed
Mar 14, 2024
| return "https://i0.wp.com/" + imageUrl.substring(schemePos + 3, imageUrl.length()) + query; | ||
| int beginIndex = schemePos + 3; | ||
| if (beginIndex < 0 || beginIndex > imageUrl.length()) { | ||
| // Fallback to original URL if the beginIndex is invalid to avoid `StringIndexOutOfBoundsException` |
There was a problem hiding this comment.
NP: It seems that imageUrl is conditionally mutated a few times prior to this. Should we tweak this code comment to not mention "original" URL? Or, alternatively, if that is what we want, store it in a local var at the top of the function and return it here without mutation? 🤔
mkevins
reviewed
Mar 14, 2024
WordPressUtils/src/main/java/org/wordpress/android/util/PhotonUtils.java
Outdated
Show resolved
Hide resolved
mkevins
approved these changes
Mar 14, 2024
|
Thank you for reviewing and your feedback @mkevins 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes wordpress-mobile/WordPress-Android#18626
WordPress-Android PR: wordpress-mobile/WordPress-Android#20459
Description
Checks the begin index before calling the substring function to prevent the
StringIndexOutOfBoundsExceptionTo test
I was not able to reproduce the issue but there are 5 different crashes rooting from this exception (see wordpress-mobile/WordPress-Android#18626 (comment))
I managed to fake one URL that reproduces the crash and added a test for it.