Skip to content
This repository was archived by the owner on Feb 4, 2025. It is now read-only.

Analytics Performance: Add access to revenue stats from range ID queries #2785

Merged
merged 14 commits into from
Jul 28, 2023
Merged

Analytics Performance: Add access to revenue stats from range ID queries #2785

merged 14 commits into from
Jul 28, 2023

Conversation

ThomazFB
Copy link
Contributor

@ThomazFB ThomazFB commented Jul 24, 2023 •
edited
Loading

⚠️ This PR has breaking changes that are connected with woocommerce/woocommerce-android#9453, do not merge it until everything is approved.

Summary

Introduces an external way to define a Revenue Stats range through an ID, making sure that we can insert/update/select any Revenue stats data through a range ID when available.

How to Test

  1. I recommend testing the changes introduced here through Analytics Performance: Improve Analytics revenue database system woocommerce/woocommerce-android#9453. Just make sure all unit tests are OK.

Update release notes:

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

ThomazFB added 13 commits July 24, 2023 17:06
@ThomazFB
Configure customRevenueId parameter inside OrderStatsRestClient.fetch…
18bc465 
…RevenueStats
@ThomazFB
Add revenueRangeId to RevenueStats payload
ea1f493
@ThomazFB
Add revenueRangeId value to fetched revenue stats before inserting it…
7ae50a3 
… into database
@ThomazFB
Add RevenueStats selection from ID value
0972a69
@ThomazFB
Add API access to revenue stats from revenue ID
f5fd1bf
@ThomazFB
Updatw WCStatsStoreTest
28d7e7c
@ThomazFB
Update WellSqlConfig with new WCRevenueStatsModel column
ce33ce6
@ThomazFB
Add rangeId field to WCRevenueStatsModel
f219b8d
@ThomazFB
Change how the revenueRangeId is set inside the OrderStatsRestClient.…
00092f6 
…fetchRevenueStats
@ThomazFB
Merge branch 'trunk' into issue/add-custom-id-to-revenue-stats
52fa0d3
@ThomazFB
Update WCStatsSqlUtils.getRevenueStatsFromRangeId with range ID query…
ab44a41 
… usage
@ThomazFB
Update database query API within WCStatsStore.getRawRevenueStatsFromR…
8f18819 
…angeId
@ThomazFB
Improve RevenueStats insertOrUpdate operation
6a1fccf
@ThomazFB ThomazFB changed the title Analytics Performance: Add access to revenue stats from ID query Analytics Performance: Add access to revenue stats from range ID queries Jul 26, 2023
@ThomazFB ThomazFB mentioned this pull request Jul 26, 2023
Merged
1 task
@ThomazFB ThomazFB requested a review from atorresveiga July 26, 2023 00:35
@atorresveiga atorresveiga self-assigned this Jul 27, 2023
atorresveiga
atorresveiga approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@atorresveiga atorresveiga left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, Thomaz! The code looks good and is working as expected. Tested alongside the Woo PR.

LGTM! :shipit:

atorresveiga
atorresveiga reviewed Jul 27, 2023
View reviewed changes
fluxc/src/main/java/org/wordpress/android/fluxc/persistence/WellSqlConfig.kt
db.execSQL("ALTER TABLE PostModel ADD AUTO_SHARE_ID INTEGER")
}
191 -> migrate(version) {
db.execSQL("ALTER TABLE WCRevenueStatsModel ADD RANGE_ID INTEGER")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

atorresveiga
atorresveiga suggested changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@atorresveiga atorresveiga left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I almost miss something 🤦

You must replace 191 -> migrate(version) to migrateAddOn(ADDON_WOOCOMMERCE, version) otherwise the WP app will crash because it doesn't have the WCRevenueStatsModel table

@ThomazFB
Copy link
Contributor Author

Wow, sorry that I forgot about this @atorresveiga, thank you so much for finding it in time to avoid a huge problem 😬 It's fixed now!

@ThomazFB ThomazFB requested a review from atorresveiga July 28, 2023 00:33
atorresveiga
atorresveiga approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@atorresveiga atorresveiga left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work Thomaz! Using the new revenueRangeId is a great addition that will make our life easier when working with the stats.

LGTM! :shipit:

@ThomazFB ThomazFB merged commit 961cf6e into trunk Jul 28, 2023
@ThomazFB ThomazFB deleted the issue/add-custom-id-to-revenue-stats branch July 28, 2023 09:36
@ParaskP7 ParaskP7 mentioned this pull request Oct 8, 2025
Merged
1 task
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@atorresveiga atorresveiga atorresveiga approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@atorresveiga atorresveiga

Labels

[Store] Woo: Stats

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ThomazFB @atorresveiga