Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle Wrapper Validation #2578

Merged
merged 3 commits into from
Nov 25, 2022
Merged

Gradle Wrapper Validation #2578

merged 3 commits into from
Nov 25, 2022

Conversation

oguzkocer
Copy link
Contributor

@oguzkocer oguzkocer commented Nov 25, 2022

In Automattic/a8c-ci-toolkit-buildkite-plugin#34 we introduced our own script to validate the Gradle Wrapper which uses the official documentation for its implementation. This PR uses that script to add a prerequisite step to validate the Gradle Wrapper in both pipelines.

The main reason we decided to add our own script as opposed to using the official Github Action was to be able to validate the Gradle Wrapper before running any of the Buildkite steps. As discussed in that PR, there are some edge cases our script doesn't cover. Furthermore, because it's a custom implementation, there is always a chance that it gets outdated. Therefore, we are adding the official Github Action alongside our own script.

After this PR is merged, I suggest we add the Github Action as a required step for trunk branch. The Buildkite step is already a prerequisite for the rest of the steps, so I don't think we need to add it as a required check, but having the Github Action as a required check should give us some extra peace of mind. Github only takes ~20s to validate the wrapper, so it shouldn't block developers unless there is an issue with it.

To Test
Verify that the Gradle Wrapper Validation is added as a prerequisite step to the Buildkite pipeline.

Screen Shot 2022-11-25 at 1 03 12 AM

@oguzkocer oguzkocer marked this pull request as ready for review November 25, 2022 06:03
@oguzkocer oguzkocer requested a review from a team November 25, 2022 06:04
@ParaskP7 ParaskP7 self-assigned this Nov 25, 2022
Copy link
Contributor

@ParaskP7 ParaskP7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 @oguzkocer !

Great work on the adding the Gradle Wrapper Validation checks in Simplenote Android! 🥇 ❤️ 🚀

I've reviewed and tested the PR as per the description and everything LGTM:

  • Configuration Changes ✅
  • Buildkite ✅
  • GitHub Actions ✅

After this PR is merged, I suggest we add the Github Action as a required step for trunk branch.

I totally agree! 💯


PS: I only have one question (❓) related to the extra notify configuration (see comment below). But, other than that I am approving the PR, I don't want to block it.

.buildkite/pipeline.yml Show resolved Hide resolved
@oguzkocer oguzkocer merged commit fcb7451 into trunk Nov 25, 2022
@oguzkocer oguzkocer deleted the add/gradle-wrapper-validation branch November 25, 2022 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants